Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra mkfs options #296

Open
mhkarimi1383 opened this issue Apr 18, 2024 · 3 comments · May be fixed by #335
Open

Extra mkfs options #296

mhkarimi1383 opened this issue Apr 18, 2024 · 3 comments · May be fixed by #335
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature kind/improvement Categorizes issue or PR as related to improving upon a current feature
Milestone
LocalPV-LVM v1.7

Comments

@mhkarimi1383
Copy link
Contributor

mhkarimi1383 commented Apr 18, 2024 •
edited by dsharma-dc
Loading

Describe the problem/challenge you have

I want to use lvm-localpv withing MinIO and some other applications with high number of Inode usage and sometimes I need to inject extra params into mkfs command

Describe the solution you'd like

Adding mkfsOptions just like mountOptions

Anything else you would like to add:
I wanted to add this feature as a PR but I don't know where to change the code to add this (I mean connecting parameters struct into formatAndMountSensitive function

(line L358 of pkg/lvm/mount.go)

Environment:

  • LVM Driver version
  • Kubernetes version (use kubectl version): 1.28
  • Kubernetes installer & version: Kubespray
  • Cloud provider or hardware configuration: Self Hosted
  • OS (e.g. from /etc/os-release): debian bookworm
@orville-wright orville-wright self-assigned this Apr 18, 2024
@orville-wright orville-wright added kind/improvement Categorizes issue or PR as related to improving upon a current feature kind/feature Categorizes issue or PR as related to a new feature labels Apr 18, 2024
@avishnu avishnu added this to the v4.3 milestone Sep 19, 2024
@avishnu
Copy link
Member

avishnu commented Sep 19, 2024

Scoping this for v4.3. Any takers from the community will be appreciated.

@avishnu avishnu added the good first issue Good for newcomers label Sep 19, 2024
@mhkarimi1383
Copy link
Contributor Author

@avishnu
I will do it

@mhkarimi1383 mhkarimi1383 linked a pull request Sep 19, 2024 that will close this issue
Open
7 tasks
@mhkarimi1383
Copy link
Contributor Author

Added in #335

@avishnu avishnu removed this from the v4.3 milestone Jan 8, 2025
@avishnu avishnu added this to the LocalPV-LVM v1.7 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature kind/improvement Categorizes issue or PR as related to improving upon a current feature
Projects
OpenEBS Roadmap Tracking
Status: No status
OEP Tracker 2024
Status: Todo
Milestone
LocalPV-LVM v1.7
Development

Successfully merging a pull request may close this issue.

feat(provisioning): extra format options (mkfs) added mhkarimi1383/lvm-localpv
3 participants
@orville-wright @avishnu @mhkarimi1383