Skip to content

Commit af9d881

Browse files
committed
Fixed to write to file even if no PV's
1 parent 9e55e2c commit af9d881

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

textfile_collector.sh

+8-5
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ function collect_pv_utilization_metrics(){
3636
done
3737
}
3838

39-
collect_and_write_to_file() {
40-
cap_metrics="$(collect_pv_capacity_metrics)"
41-
util_metrics="$(collect_pv_utilization_metrics)"
39+
write_to_file() {
40+
cap_metrics="${1:-""}"
41+
util_metrics="${2:-""}"
4242

4343
cat <<END > "${FILEPATH}"
4444
# Prometheus metrics generated by monitor-pv at $(date)
@@ -49,7 +49,6 @@ ${cap_metrics}
4949
# Utilization metrics
5050
${util_metrics}
5151
END
52-
5352
}
5453

5554
while true
@@ -72,7 +71,11 @@ do
7271

7372
if [[ ${#pv_list[@]} -ne 0 ]]; then
7473
echo "PV List: ${pv_list[@]}"
75-
collect_and_write_to_file
74+
cap_metrics="$(collect_pv_capacity_metrics)"
75+
util_metrics="$(collect_pv_utilization_metrics)"
76+
write_to_file "$cap_metrics" "$util_metrics"
77+
else
78+
write_to_file "" ""
7679
fi
7780

7881
sleep ${INTERVAL}

0 commit comments

Comments
 (0)