fix noForEach and noCatchAssign

Author: ricardo-devis-agullo

biome.json

@@ -21,7 +21,6 @@
     "rules": {
       "recommended": true,
       "complexity": {
-        "noForEach": "off",
         "useLiteralKeys": "off"
       },
       "style": {
@@ -30,7 +29,6 @@
         "useTemplate": "off"
       },
       "suspicious": {
-        "noCatchAssign": "off",
         "noExplicitAny": "off",
         "noPrototypeBuiltins": "off"
       }

src/cli/domain/handle-dependencies/get-missing-dependencies.ts

@@ -6,12 +6,12 @@ export default function getMissingDependencies(
 ): string[] {
   const missing: string[] = [];
 
-  Object.entries(dependencies).forEach(([dependency, version]) => {
+  for (const [dependency, version] of Object.entries(dependencies)) {
     const pathToModule = path.resolve('node_modules/', dependency);
     if (!moduleExists(pathToModule)) {
       missing.push(`${dependency}@${version || 'latest'}`);
     }
-  });
+  }
 
   return missing;
 }

src/cli/domain/handle-dependencies/index.ts

@@ -29,12 +29,13 @@ export default async function handleDependencies(options: {
   const { components, logger, useComponentDependencies } = options;
 
   const dependencies: Record<string, string> = {};
-  const addDependencies = (componentDependencies?: Record<string, string>) =>
-    Object.entries(componentDependencies || {}).forEach(
-      ([dependency, version]) => {
-        dependencies[dependency] = version;
-      }
-    );
+  const addDependencies = (componentDependencies?: Record<string, string>) => {
+    for (const [dependency, version] of Object.entries(
+      componentDependencies || {}
+    )) {
+      dependencies[dependency] = version;
+    }
+  };
 
   const templates: Record<string, Template> = {};
   const addTemplate = (templateName: string, template: Template) => {

src/cli/domain/handle-dependencies/require-template.ts

@@ -48,11 +48,14 @@ export default function requireTemplate(
     template
   );
 
-  [componentRelativePath, template, localTemplate, relativeTemplate].forEach(
-    (pathToTry) => {
-      ocTemplate = ocTemplate || cleanRequire(pathToTry, { justTry: true });
-    }
-  );
+  for (const pathToTry of [
+    componentRelativePath,
+    template,
+    localTemplate,
+    relativeTemplate
+  ]) {
+    ocTemplate = ocTemplate || cleanRequire(pathToTry, { justTry: true });
+  }
 
   if (!ocTemplate) {
     throw new Error(strings.errors.cli.TEMPLATE_NOT_FOUND(template));

src/cli/facade/dev.ts

@@ -108,7 +108,9 @@ const dev = ({ local, logger }: { logger: Logger; local: Local }) =>
 
       const registerPlugins = (registry: Registry) => {
         const mockedPlugins = getMockedPlugins(logger, componentsDir);
-        mockedPlugins.forEach((p) => registry.register(p));
+        for (const plugin of mockedPlugins) {
+          registry.register(plugin);
+        }
 
         registry.on('request', (data) => {
           if (data.errorCode === 'PLUGIN_MISSING_FROM_REGISTRY') {
@@ -135,10 +137,9 @@ const dev = ({ local, logger }: { logger: Logger; local: Local }) =>
       }
 
       logger.ok('OK');
-      components.forEach((component) =>
-        logger.log(colors.green('├── ') + component)
-      );
-
+      for (const component of components) {
+        logger.log(colors.green('├── ') + component);
+      }
       const dependencies = await handleDependencies({
         components,
         logger

src/cli/facade/publish.ts

@@ -133,14 +133,16 @@ const publish = ({
           } else {
             if (err.message) {
               // eslint-disable-next-line no-ex-assign
-              err = err.message;
+              errorMessage = err.message;
             } else if (err && typeof err === 'object') {
               try {
                 // eslint-disable-next-line no-ex-assign
-                err = JSON.stringify(err);
+                errorMessage = JSON.stringify(err);
               } catch (er) {}
             }
-            errorMessage = strings.errors.cli.PUBLISHING_FAIL(String(err));
+            errorMessage = strings.errors.cli.PUBLISHING_FAIL(
+              String(errorMessage)
+            );
             logger.err(errorMessage);
 
             throw errorMessage;

src/cli/facade/registry-ls.ts

@@ -24,7 +24,9 @@ const registryLs = ({
         throw err;
       }
 
-      registries.forEach((registryLocation) => logger.ok(registryLocation));
+      for (const registryLocation of registries) {
+        logger.ok(registryLocation);
+      }
 
       return registries;
     } catch (err) {

src/cli/index.ts

@@ -123,9 +123,9 @@ function processCommand(
   );
 }
 
-Object.entries(commands.commands).forEach(([commandName, command]) => {
+for (const [commandName, command] of Object.entries(commands.commands)) {
   processCommand(command, commandName, cli);
-});
+}
 
 const argv = cli
   .completion()

src/registry/domain/events-handler.ts

@@ -56,9 +56,9 @@ type EventsHandler = {
 const eventsHandler: EventsHandler = {
   fire(eventName: string, eventData: unknown): void {
     if (subscriptions[eventName]) {
-      subscriptions[eventName].forEach((callback) => {
+      for (const callback of subscriptions[eventName]) {
         callback(eventData);
-      });
+      }
     }
   },
 

src/registry/domain/plugins-initialiser.ts

@@ -27,21 +27,23 @@ function validatePlugins(plugins: unknown[]): asserts plugins is Plugin[] {
 function checkDependencies(plugins: Plugin[]) {
   const graph = new DepGraph();
 
-  plugins.forEach((p) => graph.addNode(p.name));
+  for (const plugin of plugins) {
+    graph.addNode(plugin.name);
+  }
 
-  plugins.forEach((p) => {
+  for (const p of plugins) {
     if (!p.register.dependencies) {
       return;
     }
 
-    p.register.dependencies.forEach((d) => {
+    for (const d of p.register.dependencies) {
       try {
         graph.addDependency(p.name, d);
       } catch (err) {
         throw new Error(`unknown plugin dependency: ${d}`);
       }
-    });
-  });
+    }
+  }
 
   return graph.overallOrder();
 }
@@ -64,11 +66,11 @@ export async function init(
     }
 
     let present = true;
-    dependencies.forEach((d) => {
+    for (const d of dependencies) {
       if (!registered[d]) {
         present = false;
       }
-    });
+    }
 
     return present;
   };

src/registry/router.ts

@@ -76,10 +76,10 @@ export function create(app: Express, conf: Config, repository: Repository) {
   app.get(`${prefix}:componentName`, routes.component);
 
   if (conf.routes) {
-    conf.routes.forEach((route) =>
+    for (const route of conf.routes) {
       app[
         route.method.toLowerCase() as 'get' | 'post' | 'put' | 'patch' | 'head'
-      ](route.route, route.handler)
-    );
+      ](route.route, route.handler);
+    }
   }
 }

src/registry/routes/helpers/apply-default-values.ts

@@ -16,14 +16,15 @@ export default function applyDefaultValues(
       !params[1].mandatory && typeof params[1].default !== 'undefined'
   );
 
-  optionalParametersWithDefaults.forEach(
-    ([expectedParameterName, expectedParameter]) => {
-      const param = requestParameters[expectedParameterName];
-      if (param === null || param === undefined) {
-        requestParameters[expectedParameterName] = expectedParameter.default;
-      }
+  for (const [
+    expectedParameterName,
+    expectedParameter
+  ] of optionalParametersWithDefaults) {
+    const param = requestParameters[expectedParameterName];
+    if (param === null || param === undefined) {
+      requestParameters[expectedParameterName] = expectedParameter.default;
     }
-  );
+  }
 
   return requestParameters;
 }

src/utils/put.ts

@@ -14,10 +14,10 @@ async function put(
     files = [files];
   }
 
-  files.forEach((file) => {
+  for (const file of files) {
     const fileName = path.basename(file);
     form.append(fileName, fs.createReadStream(file));
-  });
+  }
 
   const res = await got(urlPath, {
     headers: { ...headers, ...form.getHeaders() },

tasks/changelog.js

@@ -7,11 +7,11 @@ module.exports = () =>
   new Promise((resolve, reject) => {
     const writeChangelog = (changelog, cb) => {
       let result = '## Change Log';
-      changelog.forEach((pr) => {
+      for (const pr of changelog) {
         if (pr.changes.length > 0) {
           result += `\n\n### ${pr.tag.to}\n${pr.changes.join('\n')}`;
         }
-      });
+      }
       fs.writeFile(path.join(__dirname, '../CHANGELOG.md'), result, cb);
     };
 

tasks/git.js

@@ -7,7 +7,7 @@ const utils = {
   formatPrs: (commits) => {
     const result = [];
 
-    commits.forEach((commit) => {
+    for (const commit of commits) {
       const commitMessages = commit.message.split('Merge pull request');
       const isPr = commitMessages.length > 1;
       const isSquashedPr = !!commit.message.match(/(.*?)\(#(.*?)\)/g);
@@ -40,7 +40,7 @@ const utils = {
           `- [#${prNumber}](https://github.com/opencomponents/oc/pull/${prNumber}) ${commitMessage}`
         );
       }
-    });
+    }
 
     return result;
   },

tasks/mochaTest.js

@@ -35,7 +35,9 @@ const packageComponent = (componentName, done) =>
 
 const addTestSuite = (dir, done) =>
   glob(path.join(__dirname, '..', dir), (err, files) => {
-    files.forEach((file) => mocha.addFile(file));
+    for (const file of files) {
+      mocha.addFile(file);
+    }
     done();
   });
 

test/unit/cli-domain-handle-dependencies-get-missing-dependencies.js

@@ -21,7 +21,7 @@ describe('cli : domain : handle-dependencies - get-missing-dependencies', () =>
     }
   ];
 
-  scenarios.forEach((scenario) => {
+  for (const scenario of scenarios) {
     const { dependencies, installed, output } = scenario;
     describe(`When dependencies: ${JSON.stringify(
       dependencies
@@ -58,5 +58,5 @@ describe('cli : domain : handle-dependencies - get-missing-dependencies', () =>
         });
       });
     });
-  });
+  }
 });

test/unit/cli-programmatic-api.js

@@ -52,7 +52,7 @@ describe('cli : programmatic-api', () => {
     }
   ];
 
-  scenarios.forEach((scenario) => {
+  for (const scenario of scenarios) {
     describe(`cmd: cli.${scenario.cmd}`, () => {
       const fn = _.get(programmaticApi, scenario.cmd);
 
@@ -68,5 +68,5 @@ describe('cli : programmatic-api', () => {
           .that.has.all.keys(scenario.dependencies);
       });
     });
-  });
+  }
 });

test/unit/cli-validate-command.js

@@ -17,7 +17,7 @@ describe('cli : validate-command : valid', () => {
     }
   ];
 
-  scenarios.forEach((scenario) => {
+  for (const scenario of scenarios) {
     describe(`given "${scenario._.join(' ')}"`, () => {
       it(`"${scenario._[scenario.level]}" should be a valid command`, () => {
         const argv = {
@@ -28,7 +28,7 @@ describe('cli : validate-command : valid', () => {
         expect(validate(argv, level)).to.be.true;
       });
     });
-  });
+  }
 });
 
 describe('cli : validate-command : invalid', () => {
@@ -43,7 +43,7 @@ describe('cli : validate-command : invalid', () => {
     }
   ];
 
-  scenarios.forEach((scenario) => {
+  for (const scenario of scenarios) {
     describe(`given "${scenario._.join(' ')}"`, () => {
       it(`"${scenario._[scenario.level]}" should be an invalid command`, () => {
         const argv = {
@@ -56,5 +56,5 @@ describe('cli : validate-command : invalid', () => {
         }).to.throw();
       });
     });
-  });
+  }
 });

test/unit/registry-domain-options-sanitiser.js

@@ -15,11 +15,11 @@ describe('registry : domain : options-sanitiser', () => {
       timeout: 120000
     };
 
-    Object.entries(defaults).forEach(([property, value]) => {
+    for (const [property, value] of Object.entries(defaults)) {
       it(`should set ${property} to ${JSON.stringify(value)}`, () => {
         expect(sanitise(options)[property]).to.eql(value);
       });
-    });
+    }
   });
 
   describe('when verbosity is provided', () => {
@@ -108,14 +108,14 @@ describe('registry : domain : options-sanitiser', () => {
     ];
 
     it('should support various scenarios correctly', () => {
-      prefixAndBaseUrlScenarios.forEach((scenario) => {
+      for (const scenario of prefixAndBaseUrlScenarios) {
         expect(sanitise(scenario.options).prefix).to.equal(
           scenario.expected.prefix
         );
         expect(sanitise(scenario.options).baseUrl).to.equal(
           scenario.expected.baseUrl
         );
-      });
+      }
     });
   });
 

test/unit/registry-domain-validator.js

@@ -908,11 +908,11 @@ describe('registry : domain : validator', () => {
         }
       ];
 
-      scenarios.forEach((scenario) => {
+      for (const scenario of scenarios) {
         it(`should be valid with mimetype ${scenario.mimetype}`, () => {
           expect(validate([scenario]).isValid).to.be.true;
         });
-      });
+      }
     });
   });
 

test/unit/utils-npm-utils.js

@@ -27,7 +27,7 @@ describe('utils : npm-utils', () => {
       }
     ];
 
-    scenarios.forEach((scenario) => {
+    for (const scenario of scenarios) {
       const { initPath, silent } = scenario.input;
       describe(`when invoked for ${initPath} with silent=${silent}`, () => {
         let error;
@@ -60,7 +60,7 @@ describe('utils : npm-utils', () => {
           expect(onStub.args[1][0]).to.equal('close');
         });
       });
-    });
+    }
   });
 
   describe('installDependency()', () => {
@@ -115,7 +115,7 @@ describe('utils : npm-utils', () => {
       }
     ];
 
-    scenarios.forEach((scenario) => {
+    for (const scenario of scenarios) {
       const dependency = scenario.input.dependency;
       describe(`when invoked for installing ${dependency}`, () => {
         let error;
@@ -162,7 +162,7 @@ describe('utils : npm-utils', () => {
           expect(onStub.args[1][0]).to.equal('close');
         });
       });
-    });
+    }
   });
 
   describe('installDependencies()', () => {
@@ -230,7 +230,7 @@ describe('utils : npm-utils', () => {
       }
     ];
 
-    scenarios.forEach((scenario) => {
+    for (const scenario of scenarios) {
       const dependencies = scenario.input.dependencies;
       describe(`when invoked for installing [${dependencies.join(
         ', '
@@ -281,6 +281,6 @@ describe('utils : npm-utils', () => {
           expect(onStub.args[1][0]).to.equal('close');
         });
       });
-    });
+    }
   });
 });