Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Link-target gone, what should be used instead? #1868

Open
Tracked by #6196
chalin opened this issue Feb 4, 2025 · 2 comments
Open
Tracked by #6196

[editorial] Link-target gone, what should be used instead? #1868

chalin opened this issue Feb 4, 2025 · 2 comments
Labels
area:enduser bug Something isn't working

Comments

@chalin
Copy link
Contributor

chalin commented Feb 4, 2025

Originally posted by @chalin in #1456 (comment):

With this link-target gone, what should be used instead?

PR #1456 invalidated /docs/specs/semconv/general/attributes/#general-identity-attributes

docs/zero-code/java/agent/instrumentation/index.html
  hash does not exist --- docs/zero-code/java/agent/instrumentation/index.html --> /docs/specs/semconv/general/attributes/#general-identity-attributes

This path and heading ID is used in https://opentelemetry.io/docs/zero-code/java/agent/instrumentation/#peer-service-name:

Peer service name

The peer service name is the name of a remote service to which a connection is made. It corresponds to service.name in

What should be used instead?

@trask
Copy link
Member

trask commented Feb 4, 2025

@joaopgrassi joaopgrassi added bug Something isn't working area:enduser labels Feb 5, 2025
@joaopgrassi joaopgrassi moved this from Need triage to Backlog in DRAFT - SemConv Issue Triage Feb 5, 2025
@chalin
Copy link
Contributor Author

chalin commented Feb 6, 2025

I've applied your suggestion to:

I've also rebased and resolved conflicts before repushing (FYI). Checks should be are green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:enduser bug Something isn't working
Projects
Development

No branches or pull requests

3 participants