Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review BatchConfigBuilder config priority order #2592

Open
lalitb opened this issue Feb 3, 2025 · 0 comments
Open

Review BatchConfigBuilder config priority order #2592

lalitb opened this issue Feb 3, 2025 · 0 comments

Comments

@lalitb
Copy link
Member

lalitb commented Feb 3, 2025

Good catch.

I believe the priority order as discussed above should be

  • Signal specific env-variables
  • Generic env-variables
  • with_xxx compiled values.
  • default values

Quick look at BatchConfigBuilder , the priority order seems to be:

  • with_xxx compiled values
  • env-variables
  • default values

This needs to be fixed. Will raise an issue for this first.

Originally posted by @lalitb in #1225

@lalitb lalitb changed the title Review BatchConfigBuilder configuration priority order Review BatchConfigBuilder config priority order Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant