Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add timeout duration to shutdown #2574

Open
cijothomas opened this issue Jan 30, 2025 · 3 comments
Open

Add ability to add timeout duration to shutdown #2574

cijothomas opened this issue Jan 30, 2025 · 3 comments
Assignees
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@cijothomas
Copy link
Member

All Providers have shutdown() method now, and it internally uses a hardcoded 5sec timeout to perform shutdown. (usually passed on to reader/processor/exporter).
Opening an issue to let user provide their own timeout.

Option1

fn shutdown(&self, timeout: Option<Duration>)

Option2

fn shutdown(&self)
{
self.shutdown_with_timeout(5secs)
}

fn shutdown_with_timeout(&self, timeout: Duration);

I am inclined to do 2, as it keeps backward compatibility, and we can add this anytime, not necessarily before 1.0. But given https://github.com/open-telemetry/opentelemetry-rust/pull/2573/files and changes in this area, it'd be better to club them in together.

@cijothomas cijothomas added the A-common Area:common issues that not related to specific pillar label Jan 30, 2025
@cijothomas cijothomas added this to the 0.28.0 milestone Jan 30, 2025
@cijothomas cijothomas self-assigned this Jan 30, 2025
@cijothomas
Copy link
Member Author

Removing from 0.28 as option2 is additive change, and can be done post 0.28 as well.

@cijothomas cijothomas modified the milestones: 0.28.0, Logging SDK Stable Feb 6, 2025
@cijothomas cijothomas removed their assignment Feb 22, 2025
@cijothomas cijothomas added the help wanted Good for taking. Extra help will be provided by maintainers/approvers label Feb 22, 2025
@mohammadVatandoost
Copy link
Contributor

I would be happy to work on this. Please assign it to me

@cijothomas
Copy link
Member Author

@mohammadVatandoost Thanks! Assigned. To confirm - you'll be pursuing the option2 from the issue, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Development

No branches or pull requests

2 participants