OTLP Exporter builder to return more specific Error type #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottgerring @lalitb #2571 principles are followed, please review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=====================================
Coverage 79.1% 79.2%
=====================================
Files 120 119 -1
Lines 22556 22553 -3
=====================================
+ Hits 17857 17864 +7
+ Misses 4699 4689 -10 ☔ View full report in Codecov by Sentry. |
| @@ -92,6 +93,42 @@ impl Default for ExportConfig { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Error, Debug)] | |||
| /// Errors that can occur while building an exporter. | |||
| // TODO: Refine and polish this. | |||
There was a problem hiding this comment.
😇
Suggested change
| // TODO: Refine and polish this. |
4 tasks
Signed-off-by: tison <[email protected]>
Co-authored-by: Braden Steffaniak <[email protected]> Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Lalit Kumar Bhasin <[email protected]>
…2663) Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2561
Also removes now unused Error enum from Log SDK. Another set of cleanup required to clean Metrics, Traces completely.
Also, the newly introduced enum
ExporterBuildErroris not fully refined, this can be done in follow ups.Note: This is a breaking change for OTLP Exporter, however, the impact is minimal (most users/examples simply unwrap/expect the Result instead of matching on it.), as described in the changelog, so I propose to make the change even though OTLP Exporter is marked RC.