OTLP proto encoding methods are missing instrumentation scope schema url and attributes #4358
Comments
|
Sorry for the drive-by question, but why? I agree that missing schemata is a nit in the implementation, however there's some overhead, which begs to question what the benefit is. |
Hey @dimaqq, Its a good question. The spec covers the why pretty well. TLDR:
Scope level schema URLs have been in this sdk for a while and this issue just addresses not encoding the urls (and attributes - which my project needs) to OTLP protobuf messages on export. They are still optional but encoding them is a requirement of the spec. #4359 just assigns the scope schema url and attributes to the protobuf object on export. The performance impact will be negligible considering these are still optional, default to None, and encoding to otlp is an export time operation (typically called every ~30-60s if using a batch processor). |
|
Oh I see that schemata are relatively new: open-telemetry/oteps#152 |
Describe your environment
Python version: Python 3.9.21
SDK version: 1.30.0.dev
API version: 1.30.0.dev
What happened?
Spans, metrics, and logs with instrumentation scope attributes and a schema url set are missing this data when exporting to otlp proto messages. Encoding the instrumentation scope schema url and attributes are missing from opentelemetry-exporter-otlp-proto-common
Steps to Reproduce
Expected Result
The instrumentation scope schema url and attributes should show up in the otel-collector debug output
Actual Result
The instrumentation scope schema url and attributes are missing
Additional context
The
_encode_instrumentation_scopemethod is not encoding the attributesLogs encoder is not setting the
ScopeLogs.schema_urlMetrics encoder is not using the
_encode_instrumentation_scopemethod and is not setting theScopeMetrics.schema_urlTrace encoder doesn't set the
ScopeSpans.schema_urlWould you like to implement a fix?
Yes
The text was updated successfully, but these errors were encountered: