Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit b0cfe98

Browse files
committedJan 28, 2023
Reverts back to remove inetaddresss
1 parent 7760022 commit b0cfe98

File tree

4 files changed

+3
-26
lines changed

4 files changed

+3
-26
lines changed
 

‎instrumentation/apache-httpclient/commons-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/commons/ApacheHttpClientAttributesHelper.java

-8
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,6 @@ public static Integer getPeerPort(URI uri) {
9999
return uri == null ? null : uri.getPort();
100100
}
101101

102-
public static InetSocketAddress getPeerSocketAddress(HttpHost target) {
103-
if (target == null) {
104-
return null;
105-
}
106-
InetAddress inetAddress = target.getAddress();
107-
return inetAddress == null ? null : new InetSocketAddress(inetAddress, target.getPort());
108-
}
109-
110102
@Nullable
111103
private static URI getCalculatedUri(HttpHost httpHost, URI uri) {
112104
try {

‎instrumentation/apache-httpclient/commons-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/commons/ApacheHttpClientRequest.java

-5
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,6 @@ public Integer getPeerPort() {
7474
return ApacheHttpClientAttributesHelper.getPeerPort(uri);
7575
}
7676

77-
@Nullable
78-
public InetSocketAddress getPeerSocketAddress() {
79-
return ApacheHttpClientAttributesHelper.getPeerSocketAddress(target);
80-
}
81-
8277
@Override
8378
public List<String> getHeader(String name) {
8479
return ApacheHttpClientAttributesHelper.getHeader(httpRequest, name);

‎instrumentation/apache-httpclient/commons/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/commons/ApacheHttpClientNetAttributesGetter.java

+3-11
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55

66
package io.opentelemetry.javaagent.instrumentation.apachehttpclient.commons;
77

8-
import io.opentelemetry.instrumentation.api.instrumenter.net.InetSocketAddressNetClientAttributesGetter;
8+
import io.opentelemetry.instrumentation.api.instrumenter.net.NetClientAttributesGetter;
99
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
10-
import java.net.InetSocketAddress;
1110
import javax.annotation.Nullable;
1211

13-
public final class ApacheHttpClientNetAttributesGetter extends
14-
InetSocketAddressNetClientAttributesGetter<OtelHttpRequest, OtelHttpResponse> {
12+
public final class ApacheHttpClientNetAttributesGetter implements
13+
NetClientAttributesGetter<OtelHttpRequest, OtelHttpResponse> {
1514
@Override
1615
public String getTransport(OtelHttpRequest request, @Nullable OtelHttpResponse response) {
1716
return SemanticAttributes.NetTransportValues.IP_TCP;
@@ -27,11 +26,4 @@ public String getPeerName(OtelHttpRequest request) {
2726
public Integer getPeerPort(OtelHttpRequest request) {
2827
return request.getPeerPort();
2928
}
30-
31-
@Nullable
32-
@Override
33-
public InetSocketAddress getPeerSocketAddress(
34-
OtelHttpRequest request, @Nullable OtelHttpResponse response) {
35-
return request.getPeerSocketAddress();
36-
}
3729
}

‎instrumentation/apache-httpclient/commons/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/commons/OtelHttpRequest.java

-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ public interface OtelHttpRequest {
1515

1616
Integer getPeerPort();
1717

18-
InetSocketAddress getPeerSocketAddress();
19-
2018
String getMethod();
2119

2220
String getUrl();

0 commit comments

Comments
 (0)
Please sign in to comment.