Skip to content

Commit 31754ce

Browse files
TsynkPavelbaylesj
andauthored
Fixed setting JSONCPP_USE_SECURE_MEMORY definition (#1479)
* Fixed setting JSONCPP_USE_SECURE_MEMORY definition * fix indent * Fix passing from command line * simplified definition --------- Co-authored-by: Jordan Bayles <[email protected]>
1 parent 483f1c3 commit 31754ce

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

CMakeLists.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,9 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
103103
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin" CACHE PATH "Executable/dll output dir.")
104104
endif()
105105

106-
set(JSONCPP_USE_SECURE_MEMORY "0" CACHE STRING "-D...=1 to use memory-wiping allocator for STL")
106+
if(JSONCPP_USE_SECURE_MEMORY)
107+
add_definitions("-DJSONCPP_USE_SECURE_MEMORY=1")
108+
endif()
107109

108110
configure_file("${PROJECT_SOURCE_DIR}/version.in"
109111
"${PROJECT_BINARY_DIR}/version"

include/json/version.h

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
((JSONCPP_VERSION_MAJOR << 24) | (JSONCPP_VERSION_MINOR << 16) | \
1919
(JSONCPP_VERSION_PATCH << 8))
2020

21-
#ifdef JSONCPP_USING_SECURE_MEMORY
22-
#undef JSONCPP_USING_SECURE_MEMORY
23-
#endif
21+
#if !defined(JSONCPP_USE_SECURE_MEMORY)
2422
#define JSONCPP_USING_SECURE_MEMORY 0
23+
#endif
2524
// If non-zero, the library zeroes any memory that it has allocated before
2625
// it frees its memory.
2726

0 commit comments

Comments
 (0)