fix(condo): DOMA-10800 fix resident to property connections when there are more than 100 residents at the address (#5857)

* fix(condo): DOMA-10800 fix manageResidentToPropertyAndOrganizationConnections when there are more than 100 residents at the address

* fix(condo): DOMA-10800 skip test with 101 resident

Author: nomerdvadcatpyat

apps/condo/domains/resident/schema/RegisterResidentService.test.js

@@ -10,16 +10,6 @@ const {
     expectToThrowAuthenticationErrorToResult, expectToThrowAccessDeniedErrorToResult,
 } = require('@open-condo/keystone/test.utils')
 
-const { CONTEXT_FINISHED_STATUS } = require('@condo/domains/acquiring/constants/context')
-const {
-    createTestAcquiringIntegration,
-    createTestAcquiringIntegrationContext,
-} = require('@condo/domains/acquiring/utils/testSchema')
-const {
-    createTestBillingAccount,
-    makeContextWithOrganizationAndIntegrationAsAdmin,
-    createTestBillingProperty,
-} = require('@condo/domains/billing/utils/testSchema')
 const { MANAGING_COMPANY_TYPE, SERVICE_PROVIDER_TYPE } = require('@condo/domains/organization/constants/common')
 const {
     registerNewOrganization,
@@ -219,6 +209,56 @@ describe('manageResidentToPropertyAndOrganizationConnections worker task tests',
             expect(anotherResident.property.id).toEqual(olderProperty.id)
         })
     })
+
+    // Skip this test because it takes a long time
+    test.skip('Must relink many residents after approve new properties', async () => {
+        // Create admin for making Resident.getAll requests to fetch all residents in a single query
+        // instead of making 101 separate requests from resident clients.
+        const admin = await makeLoggedInAdminClient()
+        const support = await makeClientWithSupportUser()
+        const staffUserClient = await makeClientWithNewRegisteredAndLoggedInUser()
+
+        const [organization] = await registerNewOrganization(staffUserClient)
+        const [organization1] = await registerNewOrganization(staffUserClient)
+
+        const [olderProperty] = await createTestProperty(staffUserClient, organization, propertyPayload)
+        const [newerProperty] = await createTestProperty(staffUserClient, organization1, propertyPayload)
+
+        const residentsInProperty = 101
+
+        const residentIds = await Promise.all(
+            Array.from({ length: residentsInProperty }).map(async () => {
+                const residentUserClient = await makeClientWithResidentUser()
+                const [resident] = await registerResidentByTestClient(residentUserClient, { address: residentAddress, addressMeta: residentAddressMeta })
+
+                return resident.id
+            })
+        )
+
+        // NOTE: Should connect to older property
+        await waitFor(async () => {
+            const residents = await Resident.getAll(admin, { id_in: residentIds }, { first: residentsInProperty })
+
+            for (const resident of residents) {
+                expect(resident.organization?.id).toEqual(organization.id)
+                expect(resident.property?.id).toEqual(olderProperty.id)
+            }
+        })
+
+        // The newer property company requests support for ownership approval by providing a document of management rights
+        const [approvedProperty] = await updateTestProperty(support, newerProperty.id, { isApproved: true })
+        expect(approvedProperty).toHaveProperty('isApproved', true)
+
+        // // NOTE: After that all residents reconnect to newer property, since it's approved now
+        await waitFor(async () => {
+            const residents = await Resident.getAll(admin, { id_in: residentIds }, { first: residentsInProperty })
+
+            for (const resident of residents) {
+                expect(resident.organization?.id).toEqual(organization1.id)
+                expect(resident.property?.id).toEqual(newerProperty.id)
+            }
+        }, { timeout: 1000 * 60 })
+    })
 })
 
 describe('RegisterResidentService', () => {

apps/condo/domains/resident/tasks/residentTicket.task.js

@@ -31,22 +31,22 @@ async function manageResidentToPropertyAndOrganizationConnections (address, dv,
     })
 
     if (oldestProperty) {
-        const residents = await ResidentAPI.getAll(context, {
+        const residents = await find('Resident', {
             address_i: address,
             deletedAt: null,
             property: { OR: [{ id_not: oldestProperty.id }, { id: null }] },
-        }, 'id property { id }')
+        })
 
         // Disconnect residents before reconnecting
         await disconnectResidents(context, residents, dv, sender)
         // We have residents, not connected to oldest non-deleted property
         // They should be reconnected to oldestProperty
         await connectResidents(context, residents, oldestProperty, dv, sender)
     } else {
-        const residents = await ResidentAPI.getAll(context, {
+        const residents = await find('Resident', {
             address_i: address,
             deletedAt: null,
-        }, 'id property { id }')
+        })
 
         // We have no non-deleted properties with such address
         // All residents with such address should be disconnected

apps/condo/domains/resident/utils/helpers.js

@@ -27,7 +27,7 @@ const connectResidents = async (context, residents, property, dv, sender) => {
         // Already disconnected resident
         if (!shouldConnect && isNull(resident.property)) continue
         // Resident is already connected to the property
-        if (shouldConnect && get(resident, 'property.id') === propertyId) continue
+        if (shouldConnect && get(resident, 'property') === propertyId) continue
 
         await ResidentAPI.update(context, get(resident, 'id'), attrs)
     }