Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #5

Open
lbradstreet opened this issue Sep 24, 2015 · 3 comments
Open

Improvements #5

lbradstreet opened this issue Sep 24, 2015 · 3 comments

Comments

@lbradstreet
Copy link
Member

Add after-retry and after-complete to lifecycles example.
Have an example where they add submit-job (and maybe await-job-completion).
Add an example where we can manipulate catalogs/workflows/etc to show the power of data and manipulating data

@lbradstreet
Copy link
Member Author

  • Could've done with a high level overview about why you might want tasks to direct to multiple tasks (e.g. send out to a database as well as put something on queue).
  • test 1-3 should have input-output descriptions.
  • people get stuck on how params work. Might also be worth having a description about why (can modify the task data at run time, thus modify the params at run time).
  • 4-1 should explain more about what lifecycles are. Also don't use identity for the function where you want to read the batch because then you could either use onyx.core/results or onyx.core/batch.
  • Reduce reliance on capturing standard out - sucks because it's hard to add printlns
  • Move flow conditions to before lifecycles, but add a basic lifecycle example early on as it's required to use any plugin.

@lbradstreet
Copy link
Member Author

Instead of relying on capturing std-out, force users to swap!/reset! an atom from their lifecycle functions.

@jackdempsey
Copy link
Contributor

The lifecycle examples with the core/async stuff, i.e.:

;; We get a little creative to make the core.async plugin easier
;; to use. We add our own core.async/id parameter to the lifecycle
;; and reference this later to obtain a shared reference to a channel
;; via memoization.

is a little unclear. At first this seems special to this example, but then you realize it's done elsewhere. Once you realize that you look for where it's used and how and why this seemingly low level thing needs to be done at all (and isn't automatically handled).

Any clarification or work on this piece would probably be great. Happy to help if I can once I understand things better :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants