Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segments-equal? seems to be insufficient #40

Open
smee opened this issue Jan 11, 2018 · 0 comments
Open

segments-equal? seems to be insufficient #40

smee opened this issue Jan 11, 2018 · 0 comments

Comments

@smee
Copy link

smee commented Jan 11, 2018

segments-equal converts inputs and outputs to a set. That means that for example challenge 1-3 might show a valid test without duplicated outputs for the paths E-G, E-H,E-I.
Maybe this function should be

(defn segments-equal?
  "Onyx is a parallel, distributed system - so ordering isn't guaranteed.
   Does an unordered comparison of segments to check for equality."
  [expected actual]
  (is (= (frequencies expected) (frequencies actual))))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant