-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Pages Connector #2282
Comments
/bounty 250 |
💎 $250 bounty • Onyx (YC W24)Steps to solve:
Thank you for contributing to onyx-dot-app/onyx! Add a bounty • Share on socials
|
Note on the above: please check the |
/attempt #2282
|
/attempt #2282 Options |
/attempt #2282
|
@Weves |
But if the user can provide the github pages repo. |
@Weves ok how do we start ,do you need to be assigned to work on this or we can just submit our PR? |
/attempt #2282 Options |
1 similar comment
/attempt #2282 Options |
status ? |
/attempt #2282
|
/attempt #2282 Options |
1 similar comment
/attempt #2282 Options |
/attempt #2282 |
This pull request looks promising #3411 any plans to release this in the near future? My org could really use this. |
I want to work on this issue can you please assign to me @yuhongsun96 ? https://github.com/onyx-dot-app/onyx/blob/main/backend/danswer/connectors/README.md also the link is broken |
assigned |
@yuhongsun96, I had already submitted a PR for this feature back in December (#3411) and followed up last week asking if it was still needed, but didn’t receive a response. Since my PR is already implemented (though it needs conflict resolution), I would appreciate some clarity on whether it is being considered or if I should close it. Thanks! |
I see, let me take a look tomorrow or over the weekend then. @AayushSaini101 maybe hold off until I can verify |
I'm going to pass this one to @AayushSaini101. Some feedback in the proposed PR:
|
@yuhongsun96, thank you for reviewing my pr and providing feedback. I understand these areas you mentioned need improvement and I'm ready to make those changes. As I've already put in the effort to create a PR, I'd like to ensure I have the opportunity to implement your suggestions and see this through. |
@akhilender-bongirwar i have already started working on this, please check slack channel to know more about the current status of direction of your PR thanks cc: @yuhongsun96 |
@AayushSaini101, I understand you've started working on this yesterday as @yuhongsun96 suggested. However, I've already invested significant time and effort into PR's #3009, #3411, and #4233, including waiting for approvals and feedback. Just yesterday, I received first suggestions or first review for improvement on #4233, only to see the issue reassigned. You could use my existing implementation in #4233 as a foundation for your work, building upon it with the suggested modifications. This would acknowledge the work I've already done. @yuhongsun96, At the very least, I'd appreciate some form of recognition or compensation for the effort I've put into this issue, especially considering the bounty associated with it. |
Indexes all pages that are part of a Github Pages-based website. Should use the Github APIs directly, as we want to be able to index sites that are behind authentication / internal firewalls. Where possible, we should re-use functionality / common utilities present in the existing Github / Web connectors.
Checkout the connector creation README here for more details on the best way to add new connectors: https://github.com/danswer-ai/danswer/blob/main/backend/danswer/connectors/README.md.
The text was updated successfully, but these errors were encountered: