Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support angular 1.5 component() #226

Closed
lukasz-karolewski opened this issue Feb 8, 2016 · 5 comments
Closed

support angular 1.5 component() #226

lukasz-karolewski opened this issue Feb 8, 2016 · 5 comments

Comments

@lukasz-karolewski
Copy link

currently controller of the component is not properly annotated

@olov
Copy link
Owner

olov commented Feb 9, 2016

Please provide issues in the form of input, expected output, actual output. Include the version of ng-annotate and node that you are using. With pull requests, please include changes to the tests as well (tests/original.js, tests/with_annotations.js). https://github.com/olov/ng-annotate#issues-and-contributions

@Frank3K
Copy link

Frank3K commented Feb 13, 2016

@kether667: This was added in 5bfb3b1. Make sure you have the latest gulp-ng-annotate and dependencies. I had the same issue and found out that not all dependencies were up to date.

@lukasz-karolewski
Copy link
Author

thanks, yea gulp-ng-annotate specifies 'ng-annotate': '^1.0.0', which doesn't update when typing npm install

after i remove ng-annotate from node_modules it downloaded newest version

@ghost
Copy link

ghost commented Mar 14, 2016

This isn't working quite right for me. Here's my source file:
intTaskExcelImportConfig.txt

$ ng-annotate -a intTaskExcelImportConfig.txt > annotated.txt

Actual output:
annotated.txt is identical to intTaskExcelImportConfig.txt

Expected output:
I expected to see this line in annotated.txt:
Ctrl.$inject = ["$scope", "$timeout", "LocalizationService"];

I did notice that if I add /@ngInject/ then I do get the expected output. It'd be great if I didn't have to manually add this to my components since I don't do it in my directives.

ng-annotate v1.2.1

@olov
Copy link
Owner

olov commented Jun 8, 2016

#245

@olov olov closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants