split packet parsing into its own library

ChangeLog

@@ -1,6 +1,7 @@
 2013-03-23  Timothy J Fontaine  <[email protected]>
   * Add SPF record type, same as TXT
   * Emit platform ready on windows (Oleg Elifantiev)
+  * Split packet parsing into its own library
 
 2013-03-03  Timothy J Fontaine  <[email protected]>
   * Assert missing fields

dns.js

@@ -38,7 +38,7 @@ exports.resolveNs = client.resolveNs;
 exports.resolveCname = client.resolveCname;
 exports.reverse = client.reverse;
 
-var consts = require('./lib/consts');
+var consts = require('native-dns-packet').consts;
 exports.BADNAME = consts.BADNAME;
 exports.BADRESP = consts.BADRESP;
 exports.CONNREFUSED = consts.CONNREFUSED;

examples/client.js

@@ -42,7 +42,7 @@ request = dns.resolveNs('linode.com', function (err, results) {
   });
 });
 
-request = dns.resolveCname('www.google.com', function (err, results) {
+request = dns.resolveCname('www.nodejs.org', function (err, results) {
   results.forEach(function (result) {
     console.log('www.google.com -->', result);
   });

lib/client.js

@@ -26,7 +26,7 @@ var ipaddr = require('ipaddr.js'),
     EventEmitter = require('events').EventEmitter,
     PendingRequests = require('./pending'),
     Packet = require('./packet'),
-    consts = require('./consts'),
+    consts = require('native-dns-packet').consts,
     utils = require('./utils'),
     platform = require('./platform');
 
@@ -109,7 +109,7 @@ Request.prototype.handleTimeout = function() {
 
 Request.prototype.error = function(err) {
   if (!this.fired) {
-    debug('request error', this.id, this.question);
+    debug('request error', err, this.id, this.question);
     this.emit('error', err);
     this.done();
   }
@@ -179,7 +179,20 @@ var Resolve = function(opts) {
 
   this._started = false;
   this._current_server = undefined;
+
   this._server_list = [];
+  if (opts.remote) {
+    this._server_list.push({
+      address: opts.remote,
+      port: 53,
+      type: 'tcp',
+    });
+    this._server_list.push({
+      address: opts.remote,
+      port: 53,
+      type: 'udp',
+    });
+  }
 
   this._request = undefined;
   this._type = 'getHostByName';
@@ -258,7 +271,8 @@ Resolve.prototype._preStart = function() {
     this._started = new Date().getTime();
     this.try_edns = platform.edns;
 
-    this._fillServers();
+    if (!this._server_list.length)
+      this._fillServers();
   }
 };
 
@@ -376,23 +390,29 @@ Resolve.prototype._handleTimeout = function() {
   }
 };
 
-var resolve = function(domain, rrtype, callback) {
+var resolve = function(domain, rrtype, ip, callback) {
   var res;
 
+  if (!callback) {
+    callback = ip;
+    ip = undefined;
+  }
+
   if (!callback) {
     callback = rrtype;
     rrtype = undefined;
   }
 
-  rrtype = consts.NAME_TO_QTYPE[rrtype || A];
+  rrtype = consts.NAME_TO_QTYPE[rrtype || 'A'];
 
   if (rrtype === PTR) {
     return reverse(domain, callback);
   }
 
   var opts = {
     domain: domain,
-    rrtype: rrtype
+    rrtype: rrtype,
+    remote: ip,
   };
 
   res = new Resolve(opts);