Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent "site has been updated in the background" notifications for PWA #2589

Closed
taoeffect opened this issue Feb 4, 2025 · 0 comments · Fixed by #2592
Closed

Frequent "site has been updated in the background" notifications for PWA #2589

taoeffect opened this issue Feb 4, 2025 · 0 comments · Fixed by #2592

Comments

@taoeffect
Copy link
Member

taoeffect commented Feb 4, 2025

Problem

On Android with a Brave PWA, I am getting these notifications entirely too frequently (many times an hour):

Image

What's more, is that these notifications often come in pairs for both the live site and testing, at the same time. This indicates that something else is going on than contract activity, especially the contracts in both don't have much activity.

Solution

  • First find out why this is happening, perhaps by using more verbose logging with console.info (will the logs be captured if the PWA isn't open..?)
  • Then fix it so that they appear only to the minimum extent necessary.

EDIT: @corrideat has a theory that it may be that we're broadcasting KV updates over push. If so, we should disable this, as I see no reason to do so. Disabling will cause this message to appear less frequently. When we come back online (because the user opens the app) we should immediately query the KV stores for updates.

These KV updates are being broadcast multiple times a minute on the debug server, which almost nobody is using, so these definitely shouldn't be sent over push anyway:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants