feat: option to disable price feeder ticks for full nodes (#522)

* feat: option to disable price feeder ticks for full nodes

* enable price feeder appconfig setting in e2e tests

* e2e typo

* price feeder cmd fix

Author: adamewozniak

cmd/ojod/cmd/commands.go

@@ -128,6 +128,7 @@ func initRootCmd(
 	// add price feeder flags
 	rootCmd.PersistentFlags().String(pricefeeder.FlagConfigPath, "", "Path to price feeder config file")
 	rootCmd.PersistentFlags().String(pricefeeder.FlagLogLevel, "", "Log level of price feeder process")
+	rootCmd.PersistentFlags().Bool(pricefeeder.FlagEnablePriceFeeder, false, "Enable the price feeder")
 }
 
 // genesisCommand builds genesis-related `simd genesis` command. Users may

pricefeeder/config.go

@@ -15,18 +15,23 @@ config_path = ""
 
 # Log level of price feeder process.
 log_level = "info"
+
+# Enable the price feeder.
+enable = false
 `
 )
 
 const (
-	FlagConfigPath = "pricefeeder.config_path"
-	FlagLogLevel   = "pricefeeder.log_level"
+	FlagConfigPath        = "pricefeeder.config_path"
+	FlagLogLevel          = "pricefeeder.log_level"
+	FlagEnablePriceFeeder = "pricefeeder.enable"
 )
 
 // AppConfig defines the app configuration for the price feeder that must be set in the app.toml file.
 type AppConfig struct {
 	ConfigPath string `mapstructure:"config_path"`
 	LogLevel   string `mapstructure:"log_level"`
+	Enable     bool   `mapstructure:"enable"`
 }
 
 // ValidateBasic performs basic validation of the price feeder app config.
@@ -57,6 +62,12 @@ func ReadConfigFromAppOpts(opts servertypes.AppOptions) (AppConfig, error) {
 		}
 	}
 
+	if v := opts.Get(FlagEnablePriceFeeder); v != nil {
+		if cfg.Enable, err = cast.ToBoolE(v); err != nil {
+			return cfg, err
+		}
+	}
+
 	if err := cfg.ValidateBasic(); err != nil {
 		return cfg, err
 	}

tests/e2e/orchestrator/orchestrator.go

@@ -335,6 +335,7 @@ func (o *Orchestrator) runValidators(t *testing.T) {
 			"start",
 			"--pricefeeder.config_path=/root/pricefeeder/price-feeder.example.toml",
 			"--pricefeeder.log_level=info",
+			"--pricefeeder.enable=true",
 		}
 
 		runOpts := &dockertest.RunOptions{

x/oracle/abci/endblocker.go

@@ -32,8 +32,8 @@ func EndBlocker(ctx context.Context, k keeper.Keeper) error {
 
 	params := k.GetParams(sdkCtx)
 
-	// Start price feeder if it hasn't been started.
-	if k.PriceFeeder.Oracle == nil {
+	// Start price feeder if it hasn't been started, and it is enabled.
+	if k.PriceFeeder.Oracle == nil && k.PriceFeeder.AppConfig.Enable {
 		go func() {
 			err := k.PriceFeeder.Start(sdkCtx.BlockHeight(), params)
 			if err != nil {
@@ -51,7 +51,7 @@ func EndBlocker(ctx context.Context, k keeper.Keeper) error {
 	}
 
 	if k.IsPeriodLastBlock(sdkCtx, params.VotePeriod) {
-		if k.PriceFeeder.Oracle != nil {
+		if k.PriceFeeder.Oracle != nil && k.PriceFeeder.AppConfig.Enable {
 			// Update price feeder oracle with latest params.
 			k.PriceFeeder.Oracle.ParamCache.UpdateParamCache(sdkCtx.BlockHeight(), k.GetParams(sdkCtx), nil)