Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

survey_response/read doesn't allow both survey_id_list and prompt_id_list #896

Open
krozett opened this issue Jul 11, 2016 · 0 comments
Open

Comments

@krozett
Copy link

krozett commented Jul 11, 2016

The documentation doesn't suggest that the two are mutually exclusive. Furthermore if you try to make a request where both are present, you get an error message:

Both a survey list (survey_id_list) and a prompt list (prompt_id_list) must be given.

Going by the code here:

else if(((tSurveyIds != null) && (tSurveyIds.size() > 0)) &&

It looks like it doesn't allow both to be passed in, but that's the opposite of what the error message says. I'm not familiar with the internals of Ohmage, but it doesn't seem reasonable to make this restriction. We have a case where we want to get all responses to a given question in a given survey, and we are forced to pass in only the prompt_id_list. This isn't a huge deal since all our surveys have unique prompt ids, but I can see this being a problem for others who have the same prompt ids in different surveys.

Please either remove the restriction, or make the error message and documentation consistent with the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant