Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Font versioning #1694

Open
johnf opened this issue Jan 9, 2025 · 2 comments
Open

RFC: Font versioning #1694

johnf opened this issue Jan 9, 2025 · 2 comments

Comments

@johnf
Copy link
Collaborator

johnf commented Jan 9, 2025

@vonovak @brentvatne @oblador

I'm input on how we should version the font packages.

One of my goals was that the version of the font packages should match upstream.

The issue is sometimes we need to update a font package when there is no upstream change, e.g. #1682

My current thought was to do something like this

Upstream Action Our Version
1.0.0 Font update 1.0.0
1.0.0 Code change 1.0.1-really-1.0.0-v1
1.0.0 Code change 1.0.1-really-1.0.0-v2
1.0.1 Font and code update 1.0.1

I did some testing a while back, and while this approach should work, it is still reasonably ugly.

I thought about a four digit semver, but my research indicates it will break tools.

My latest thought is that if the font version is 6.7.2, our version starts at 1006.1007.1002, and we can bump the first digit.

Does anyone have a better idea or preference on the above?

@johnf
Copy link
Collaborator Author

johnf commented Jan 9, 2025

The other alternative is we don't try to follow upstream at all and have a table in the README of which RNVI font versions map to which upstream versions

@vonovak
Copy link
Contributor

vonovak commented Jan 11, 2025

hello @johnf - I'd go with the readme table. It's simple, effective, easy to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants