Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message to logs #68

Open
AndersBennedsgaard opened this issue Apr 4, 2024 · 0 comments
Open

Add error message to logs #68

AndersBennedsgaard opened this issue Apr 4, 2024 · 0 comments

Comments

@AndersBennedsgaard
Copy link

Describe the bug

When errors occur, it is important to get the error message logged out. Otherwise it can get very annoying to debug. I have for example hit the following error:

util.Fatal("failed to create Watcher")

I don't know why fsnotify.NewWatcher() would fail, but since the error message isn't included in the error log, it is almost impossible to debug.

Expected behaviour

I would expect the error message is a part of the logs using something like the following:

util.Fatal(fmt.Sprintf("failed to create Watcher: %v", err))

Additional context

I actually came onto this error by using https://github.com/hpcloud/tail which is used in https://github.com/kubeflow/katib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant