Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding column numbers in live_grep picker #2420

Open
Imberflur opened this issue Mar 13, 2023 · 3 comments
Open

Allow hiding column numbers in live_grep picker #2420

Imberflur opened this issue Mar 13, 2023 · 3 comments
Labels
enhancement Enhancement to performance, inner workings or existent features

Comments

@Imberflur
Copy link

Imberflur commented Mar 13, 2023

Is your feature request related to a problem? Please describe.
When using live_grep the column numbers can sometimes be unnecessary visual clutter for me. However, as far as I've been able to find the only option available for toggling them off is disable_coordinates which also removes line numbers.

I might just be missing something though! I've just started trying out telescope.

Describe the solution you'd like
A way to configure just column numbers to be disabled.

Describe alternatives you've considered
Maybe there would be some way to allow the user to provide a custom function that performs the formatting of line/column numbers? Similar to the path_display option?

@Imberflur Imberflur added the enhancement Enhancement to performance, inner workings or existent features label Mar 13, 2023
@Imberflur
Copy link
Author

Imberflur commented Mar 13, 2023

I managed to hack in a disable_column here Imberflur@b370779 but I don't know if this approach is ideal since this then has some overlap with the functionality of disable_coordinates.

@Imberflur
Copy link
Author

Hi! I just realized I'm still using this. If there is interest, I would be willing to work on making this ready for a PR.

@jamestrew
Copy link
Contributor

This PR will consolidate a lot of the logic of displaying filepaths and lnum/cols for any picker that displays these #3200

I would at least wait until that is merged and then we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to performance, inner workings or existent features
Projects
None yet
Development

No branches or pull requests

2 participants