Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flags may not reside in config.ConfigManager.BASE_ONLY_SECTIONS #17723

Open
LeonarddeR opened this issue Feb 21, 2025 · 1 comment
Open

Feature flags may not reside in config.ConfigManager.BASE_ONLY_SECTIONS #17723

LeonarddeR opened this issue Feb 21, 2025 · 1 comment
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers feature/configuration Making NVDA more configurable. good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@LeonarddeR
Copy link
Collaborator

Steps to reproduce:

Add a Feature Flag to the general config section as in #17651

Actual behavior:

Feature flags in base only sections are not supported. Feature flags rely on support in config.AggregatedSection to validate the flag after setting it. This doesn't work in the base only sections, where configobj.Section is used.

Expected behavior:

Feature flags in base only config sections work as expected.
@LeonarddeR LeonarddeR mentioned this issue Feb 21, 2025
Merged
5 tasks
@gerald-hartig gerald-hartig added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. good first issue github features these at https://github.com/nvaccess/nvda/contribute audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers feature/configuration Making NVDA more configurable. labels Feb 24, 2025
@gerald-hartig
Copy link
Collaborator

Can be addressed subclassing configObj, and move logic from aggregated sections to handle feature flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers feature/configuration Making NVDA more configurable. good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeonarddeR @gerald-hartig