Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download add-on update before opening the add-on update dialog #17722

Open
CyrilleB79 opened this issue Feb 21, 2025 · 0 comments
Open

Download add-on update before opening the add-on update dialog #17722

CyrilleB79 opened this issue Feb 21, 2025 · 0 comments
Labels
feature/addon-store Features / behavior of the add-on Store good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

CyrilleB79 commented Feb 21, 2025

Steps to reproduce:

  1. Wait for an add-on update to be available (or spoof it)
  2. Wait for the update all add-ons dialog to pops up
  3. Press "Update all" button to update all add-ons
  4. Try to close the dialog:
    • Press "Close"
    • (sometimes) the dialog indicates that some add-ons are still downloading and offers to cancel the download
    • Press "No" to continue downloading
    • Repeat these steps 2 or 3 times depending on the availability of internet / wifi connection, the download rate and the size of the content to be downloaded
  5. Close the dialog; this time no more add-ons are downloading
  6. Restart NVDA when asked to

Actual behavior:

Step 4. is a frustrating UX.

Expected behavior:

NVDA should offer to update the add-ons only once they are already downloaded in order to avoid step 4.

Alternatively, an option can be created to choose between this new UX and the current UX (i.e. prompt to update and hten download) if we consider that the current UX is still useful.

The question remains open for the Updatable add-ons tab in the add-on store, but I'd say that they should be downloaded too, at least on the current add-on's channel.

NVDA logs, crash dumps and other attachments:

N/A

System configuration

NVDA installed/portable/running from source:

Installed and from source

NVDA version:

2024.4.2 and alpha c756899

Windows version:

Windows 10 22H2 (AMD64) build 19045.5371

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

N/A

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A

@gerald-hartig gerald-hartig added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority ux triaged Has been triaged, issue is waiting for implementation. labels Feb 24, 2025
@gerald-hartig gerald-hartig added this to the 2025.2 milestone Feb 24, 2025
@gerald-hartig gerald-hartig added good first issue github features these at https://github.com/nvaccess/nvda/contribute feature/addon-store Features / behavior of the add-on Store labels Feb 24, 2025
@seanbudd seanbudd modified the milestones: 2025.2, 2025.1 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/addon-store Features / behavior of the add-on Store good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Projects
None yet
Development

No branches or pull requests

3 participants