Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing SAPI4 synth driver in 2026.1 #17647

Closed
SaschaCowley opened this issue Jan 24, 2025 · 2 comments
Closed

Consider removing SAPI4 synth driver in 2026.1 #17647

SaschaCowley opened this issue Jan 24, 2025 · 2 comments
Labels
api-breaking-change blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. maintenance needs-triage
Milestone
2026.1

Comments

@SaschaCowley
Copy link
Member

Is your feature request related to a problem? Please describe.

SAPI4 is no longer maintained or supported. It is known to rely on libraries that pose a security risk. In #17599 SAPI4 was deprecated, and a message added to warn users of its pending removal.

Describe the solution you'd like

Remove synthDrivers.sapi4 and synthDrivers._sapi4. Remove mentions of SAPI4 from the user guide.

Describe alternatives you've considered

Keep the SAPI4 code. It only makes vulnerable calls if in use, so poses little risk to most users.

Additional context
@seanbudd
Copy link
Member

Can you create and assign a 2026.1 milestone to this?

@SaschaCowley SaschaCowley added this to the 2026.1 milestone Jan 24, 2025
@SaschaCowley SaschaCowley added p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. and removed component/speech-synth-drivers labels Jan 27, 2025
@SaschaCowley SaschaCowley mentioned this issue Feb 6, 2025
Merged
5 tasks
@seanbudd seanbudd changed the title Remove SAPI4 synth driver in 2026.1 Consider removing SAPI4 synth driver in 2026.1 Feb 19, 2025
@seanbudd seanbudd added maintenance blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage and removed p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Feb 19, 2025
@seanbudd
Copy link
Member

Closing this issue. The primary security concerns around removing SAPI 4 have been determined to be unwarranted. The potential (but only theoretical) security vector related to SAPI 4 is being fixed in #17718

@seanbudd seanbudd closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-breaking-change blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. maintenance needs-triage
Projects
None yet
Milestone
2026.1
Development

No branches or pull requests
2 participants
@seanbudd @SaschaCowley