Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on store: when you click the update all button several times, one add-on downloads many times #17110

Closed
alekssamos opened this issue Sep 3, 2024 · 0 comments · Fixed by #17713
Closed

Add-on store: when you click the update all button several times, one add-on downloads many times #17110

alekssamos opened this issue Sep 3, 2024 · 0 comments · Fixed by #17713
Labels
feature/addon-store Features / behavior of the add-on Store p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2025.1

Comments

@alekssamos
Copy link

Steps to reproduce:

  • Have a slow internet connection
  • Install an old version of a large add-on for example, clock version 25.
  • Restart NVDA until the dialog for updating the add-on to version, for example, 31, appears.

Actual behavior:

There is one addon in the list. Click the update all button, the download begins. Click the update all button many times, for example, 6 times and it will be written in the window that six add-ons are being downloaded

Expected behavior:

Make sure that if the add-on is downloaded (or is it still downloading), do not re-download it.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed

NVDA version: 2024.3

Windows version: 10
@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. feature/addon-store Features / behavior of the add-on Store labels Sep 10, 2024
@seanbudd seanbudd added this to the 2025.1 milestone Sep 10, 2024
@seanbudd seanbudd mentioned this issue Feb 20, 2025
Merged
5 tasks
gexgd0419 pushed a commit to gexgd0419/nvda that referenced this issue Feb 22, 2025
@seanbudd @gexgd0419
Allow update all add-ons button to be pressed only once (nvaccess#17713)
29cb7f0 
Fixes nvaccess#17110

Summary of the issue:
Ever since nvaccess#16636, users have been able to press the "update all" button to execute downloading and installing all the add-ons multiple times. This is because the update all button is disabled after the add-ons have finished downloading, not immediately after it is clicked, preventing subsequent activations.

Description of user facing changes
Users are unable to press update all button multiple times until add-ons finish downloading.

Description of development approach
Disable update all button immediately after first activation.

Testing strategy:
Manual testing by simulating slow internet updating multiple add-ons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/addon-store Features / behavior of the add-on Store p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2025.1
Development

Successfully merging a pull request may close this issue.

Allow update all add-ons button to be pressed only once nvaccess/nvda
2 participants
@seanbudd @alekssamos