Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs contributors count limited to 30 (minus bots) #295

Open
BobbieGoede opened this issue Oct 10, 2024 · 3 comments
Open

Docs contributors count limited to 30 (minus bots) #295

BobbieGoede opened this issue Oct 10, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@BobbieGoede
Copy link
Member

BobbieGoede commented Oct 10, 2024

📚 Is your documentation request related to a problem?

The homepage displays a contributors count, I assume this is meant to be the total contributors of this project, but the request https://ungh.cc/repos/nuxt/scripts/contributors is limited to return the default paginated amount of contributors (30).

I suppose ungh should allow passing query parameters to raise this, but the max results you can query is 100 (https://api.github.com/repos/nuxt/scripts/contributors?per_page=100). I'll open an issue there as well.

🔍 Where should you find it?

https://scripts.nuxt.com/

ℹ️ Additional context

I'm working on improving https://i18n.nuxtjs.org/ and came across this while checking if I could add a contributor count/appreciation section.

@BobbieGoede BobbieGoede added the documentation Improvements or additions to documentation label Oct 10, 2024
@BobbieGoede
Copy link
Member Author

Related to unjs/ungh#74

With unjs/ungh#76 the count per page could be raised and make it possible to get the results through multiple requests.

This issue is not a big deal (right now in this repo with 32 contributors) but figured it would look nicer with an accurate count, and prevent confusion across modules showing the same!

@shinGangan
Copy link
Contributor

Hi @BobbieGoede , I support this change.

I understand that it will be two-step process as follows, but is my understanding correct?

  1. Migrate Nuxt API to GitHub API(https://api.github.com/repos/nuxt/scripts/contributors)
  2. Migrate ungh to after unjs/ungh#76 support

harlan-zw added a commit that referenced this issue Oct 14, 2024
@harlan-zw
Copy link
Collaborator

Thanks for the issue, I'm working on a new docs template and will have this solved in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants