-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate: xxl
and 2xl
is the same thing
#1633
Comments
I see. Thanks for clarification! Then I think it makes sense but I wonder if it wouldn't be a breaking change? If someone was using current xxl size? @danielroe what do you think? |
I think having an extra screen property is useful for backwards compatibility. (we can remove in next major) I don't think it harms anything to keep it, though we can remove it from the docs if it is there. It's a superset of Tailwind. |
Ok so let's maybe approach it this way:
@razbakov could you modify your PR with that? :) |
@Baroshem sure, can you show me how to make it deprecated? |
As this is an object and not a type, maybe we could add a note in the documentation instead of in the TS code? Something like https://nuxt-security.vercel.app/utils/remove-console-loggers#alternative-method-deprecated |
@danielroe the point 2 is not done |
I think let's not deprecate it for now. It seems harmless. |
There is a contradiction in configuration screens.
Either this message should be adjusted or the extra property should be removed.
There are 2 ways to name sizes:
Or:
Counting letters is more difficult than reading the number.
And xxl duplicates the value of 2xl.
The text was updated successfully, but these errors were encountered: