Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a good idea to use latest version in all packages? #165

Open
shirohana opened this issue Nov 8, 2017 · 5 comments
Open

Is it a good idea to use latest version in all packages? #165

shirohana opened this issue Nov 8, 2017 · 5 comments

Comments

@shirohana
Copy link

shirohana commented Nov 8, 2017

I see bulma was already in 0.6.1 but in @nuxtjs/bulma was just ^0.5.1.

Since you use a helper module, that means you didn't care about which version you
used but it should be the newest one.

I mean, if you want to use the older version, just look around how @nuxtjs/bulma
was made and specify the version when adding it, and no needs to send a issue or pr
for upgrading dependencies in @nuxtjs/modules anymore.

"dependencies": {
  "bulma": "latest"
}

https://github.com/nuxt-community/modules/blob/master/packages/bulma/package.json#L12

This question is available on Nuxt.js community (#c98)
@clarkdo
Copy link
Member

clarkdo commented Nov 13, 2017

I think the modules should not depend these frameworks directly, maybe peerDependencies is a choice.

We can let users add specific version dependency by themselves.

@atinux @pi0 What do you think about ?

@core01
Copy link

core01 commented Apr 24, 2018

Bulma is v0.7.0 now, but in nuxtjs is v0.6.1 only.
Is there any workaround how to use latest bulma?
I found that I can to not use this module in my project, everything works well with bulma as project dependency!

@anteriovieira
Copy link
Member

@clarkdo I agree with you, in that case, we would have to implement peerDependencies on all modules, right?

@clarkdo
Copy link
Member

clarkdo commented May 29, 2018

@anteriovieira Yeah, we may change it one by one and keep discussing. 😸

@anteriovieira
Copy link
Member

Okay, so I'm going to start with a pull request for @nuxtjs/bulma 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants