-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdk boards previews #759
base: main
Are you sure you want to change the base?
Sdk boards previews #759
Conversation
Signed-off-by: Mikhail Aheichyk <[email protected]>
🦋 Changeset detectedLatest commit: c0ae825 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Mikhail Aheichyk <[email protected]>
…cation. Signed-off-by: Mikhail Aheichyk <[email protected]>
const widgetApi = await (extra as ThunkExtraArgument).widgetApi; | ||
|
||
try { | ||
const roomIdParameter: string | undefined = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here, so that we can remember why it is like it is in half a year or so? :D
@@ -117,8 +127,13 @@ export const documentSnapshotApi = baseApi.injectEndpoints({ | |||
validator, | |||
); | |||
|
|||
const options = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a comment here please
Otherwise tested and works ✔️ |
Updates SDK. Please review per commit.
✔️ Checklist
Signed-off-by
line in the message (more info).