Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk boards previews #759

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sdk boards previews #759

wants to merge 3 commits into from

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Feb 25, 2025

Updates SDK. Please review per commit.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: c0ae825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nordeck/matrix-neoboard-react-sdk Minor
@nordeck/matrix-neoboard-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mikhail Aheichyk added 2 commits February 25, 2025 17:54
@maheichyk maheichyk marked this pull request as ready for review February 25, 2025 15:52
@maheichyk maheichyk requested a review from a team as a code owner February 25, 2025 15:52
@weeman1337 weeman1337 self-requested a review February 26, 2025 12:22
const widgetApi = await (extra as ThunkExtraArgument).widgetApi;

try {
const roomIdParameter: string | undefined =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here, so that we can remember why it is like it is in half a year or so? :D

@@ -117,8 +127,13 @@ export const documentSnapshotApi = baseApi.injectEndpoints({
validator,
);

const options =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a comment here please

@weeman1337
Copy link
Contributor

Otherwise tested and works ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants