Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-http-header-overflow has passed only if socket buffer is more than 16Kb #46291

Closed
dmitry-chukanov opened this issue Jan 20, 2023 · 0 comments
Closed

test-http-header-overflow has passed only if socket buffer is more than 16Kb #46291

dmitry-chukanov opened this issue Jan 20, 2023 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.

Comments

@dmitry-chukanov
Copy link

Test

test-http-header-overflow

Platform

Linux x64

Console output

No response

Build links

Additional information

If socket buffer is less or equal than 16Kb then overflowed HTTP header (its size >16Kb) has two chunks: the first one is read from the socket and all is good, but after second chunk reading we have throw error (we wait this error) with data buffer only from second chunk. But we try to validate not only the error code, but also whole data buffer with overflowed HTTP header. But current error object has not whole data buffer, it has only second chunk from posix read() and test is fail.
The most simple way to fix - don't check data (bytesParsed and rawPacket) at error, check only name, message and code. But perhaps there is more complex way to solve this problem.
@dmitry-chukanov dmitry-chukanov added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jan 20, 2023
@github-actions github-actions bot added the linux Issues and PRs related to the Linux platform. label Jan 20, 2023
lpinca added a commit to lpinca/node that referenced this issue Sep 17, 2024
@lpinca
test: deflake test-http-header-overflow
8259fdb 
Skip the network and push the data directly to the receiving socket
so that it is guaranteed to be received as a single chunk.

Fixes: nodejs#46291
@lpinca lpinca mentioned this issue Sep 17, 2024
Closed
targos pushed a commit that referenced this issue Oct 4, 2024
@lpinca @targos
test: deflake test-http-header-overflow
341b6d9 
Skip the network and push the data directly to the receiving socket
so that it is guaranteed to be received as a single chunk.

Fixes: #46291
PR-URL: #54978
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@lpinca @louwers
test: deflake test-http-header-overflow
5461645 
Skip the network and push the data directly to the receiving socket
so that it is guaranteed to be received as a single chunk.

Fixes: nodejs#46291
PR-URL: nodejs#54978
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake test-http-header-overflow lpinca/node
1 participant
@dmitry-chukanov