Run secureTagRelease() asynchronously

codebytere · codebytere · commit c1ab158b0bbf · 2020-05-20T11:52:23.000-07:00
diff --git a/lib/promote_release.js b/lib/promote_release.js
@@ -238,7 +238,7 @@ class ReleasePromotion {
     return this.config.username;
   }
 
-  secureTagRelease() {
+  async secureTagRelease() {
     const { version, isLTS, ltsCodename } = this;
 
     const secureTag = path.join(
@@ -254,7 +254,7 @@ class ReleasePromotion {
       `${this.date} Node.js v${version} ${releaseInfo} Release`
     ];
 
-    return runSync(secureTag, secureTagOptions);
+    await runAsync(secureTag, secureTagOptions);
   }
 
   // Set up the branch so that nightly builds are produced with the next

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ class ReleasePromotion {`
`238`	`238`	`return this.config.username;`
`239`	`239`	`}`
`240`	`240`
`241`		`- secureTagRelease() {`
	`241`	`+ async secureTagRelease() {`
`242`	`242`	`const { version, isLTS, ltsCodename } = this;`
`243`	`243`
`244`	`244`	`const secureTag = path.join(`
`@@ -254,7 +254,7 @@ class ReleasePromotion {`
`254`	`254`	`${this.date} Node.js v${version} ${releaseInfo} Release`
`255`	`255`	`];`
`256`	`256`
`257`		`- return runSync(secureTag, secureTagOptions);`
	`257`	`+ await runAsync(secureTag, secureTagOptions);`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`// Set up the branch so that nightly builds are produced with the next`