Skip to content

Commit ba67a3c

Browse files
committed
chore(git-node): Add make lint-md reminder
After two consecutive releases in which I mistakely pushed a broken release commit to main, I'm convinced that the process needs improvement. This changeset proposes to add a reminder to `git node release promote` to lint markdown files prior to pushing branches to upstream remote. Refs: nodejs/node@a344300 Refs: nodejs/node#56508
1 parent 4bd6820 commit ba67a3c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

lib/promote_release.js

+6
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,12 @@ export default class ReleasePromotion extends Session {
195195
}
196196
}
197197

198+
cli.separator();
199+
cli.warn('Reminder: Lint markdown files');
200+
cli.info('You might need to amend the commit if there are issues:');
201+
cli.info('make lint-md');
202+
cli.separator();
203+
198204
// Push to the remote the release tag, and default, release, and staging branch.
199205
await this.pushToRemote(workingOnNewReleaseCommit);
200206

0 commit comments

Comments
 (0)