-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.4.2 missing some files #110
Comments
removing things would make it a breaking change - v2. v1.5 would be a minor, for adding things. |
Good point, I guess 2.0.0 |
I've talked a bit with @guybedford so far, but have not landed on the best way to resolve yet. As I understand it the missing files will likely only impact a very small number of users so I think its best to figure out the right way to proceed vesus rushing something. |
I ran |
Ok after talking with Guy, tagged the same content as 1.4.1 as 1.4.3, edited the package.json to change to 1.4.3 and then ran an npm publish |
Unfortunately, this means that when you pull the sources from github, the package.json still declares it to be a version For context, I'm pulling the sources from here because the tarball published at npmjs.com does not contain the test suite, and I want to be able to run it during packaging. |
@khardix the issue you mentioned in terms of the env vars is now fixed and published in 2.1.0 |
I believe I likely should have made the new release 1.5.0 as I've discovered some files were removed.
Discussing with @guybedford to agree on what should be done.
The text was updated successfully, but these errors were encountered: