Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4.2 missing some files #110

Closed
mhdawson opened this issue Jan 30, 2025 · 7 comments
Closed

Version 1.4.2 missing some files #110

mhdawson opened this issue Jan 30, 2025 · 7 comments

Comments

@mhdawson
Copy link
Member

I believe I likely should have made the new release 1.5.0 as I've discovered some files were removed.

Discussing with @guybedford to agree on what should be done.

@ljharb
Copy link
Member

ljharb commented Jan 30, 2025

removing things would make it a breaking change - v2. v1.5 would be a minor, for adding things.

@mhdawson
Copy link
Member Author

Good point, I guess 2.0.0

@mhdawson
Copy link
Member Author

I've talked a bit with @guybedford so far, but have not landed on the best way to resolve yet.

As I understand it the missing files will likely only impact a very small number of users so I think its best to figure out the right way to proceed vesus rushing something.

@mhdawson
Copy link
Member Author

I ran npm dist-tag add [email protected] latest to set latest as 1.4.1 which I think should cut down how many people might pull 1.4.2 until we publish a new minor.

@mhdawson
Copy link
Member Author

Ok after talking with Guy, tagged the same content as 1.4.1 as 1.4.3, edited the package.json to change to 1.4.3 and then ran an npm publish

@khardix
Copy link
Contributor

khardix commented Jan 31, 2025

Unfortunately, this means that when you pull the sources from github, the package.json still declares it to be a version 1.4.1. This confused me for a bit while working on Fedora update, until I found this issue. I'll try to convince our update checker to ignore these two updates until it is sorted out.

For context, I'm pulling the sources from here because the tarball published at npmjs.com does not contain the test suite, and I want to be able to run it during packaging.

@mhdawson
Copy link
Member Author

@khardix the issue you mentioned in terms of the env vars is now fixed and published in 2.1.0

@mhdawson mhdawson reopened this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants