Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure NIC pods with zone_sync enabled without TLS support #7219

Open
7 tasks done
AlexFenlon opened this issue Jan 27, 2025 · 1 comment · May be fixed by #7347
Open
7 tasks done

Configure NIC pods with zone_sync enabled without TLS support #7219

AlexFenlon opened this issue Jan 27, 2025 · 1 comment · May be fixed by #7347
Assignees
Labels
proposal An issue that proposes a feature request

Comments

@AlexFenlon
Copy link
Contributor

AlexFenlon commented Jan 27, 2025

Is your feature request related to a problem? Please describe.
As an engineer, I want zone_sync to a feature for NIC to allow state sharing.
Prereq: #7218

Acceptance Criteria

  • No TLS for this issue
  • zone-sync data read from the nginx-config (ConfigMap)
  • input data validated
  • generate headless service (no user input, read namespace name only)

headless service example:

apiVersion: v1
kind: Service
metadata:
  name: nginx-ingress-headless
  namespace: nginx-ingress
spec:
  clusterIP: None
  selector:
    app: nginx-ingress

-- lookup selector:app value from NIC deployment obj - it will be the name for app:selector in the headless service (we match NIC deployment with the headless service)
-- on NIC startup -> create headless service (K8s API call) - (?) Do we start NIC if this call fails?
-- learn where to put the code (controller.go ?) for managing config map zone-sync changes - during runtime
-- we need to remove headless service when user removes zone-sync (or set to false) from the nginx-ingress config map
-- we need to add headless service when user enables zone-sync (or set to true) in the nginx-ingress config map

  • templates generate correct zone-sync config
  • Manifest implementation
  • Update Documentation
    • ready once this pr goes in
@AlexFenlon AlexFenlon added the proposal An issue that proposes a feature request label Jan 27, 2025
Copy link

Hi @AlexFenlon thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@AlexFenlon AlexFenlon self-assigned this Jan 27, 2025
@jjngx jjngx moved this from Todo ☑ to In Progress 🛠 in NGINX Ingress Controller Jan 30, 2025
@AlexFenlon AlexFenlon moved this from In Progress 🛠 to In Review 👀 in NGINX Ingress Controller Feb 12, 2025
@AlexFenlon AlexFenlon moved this from In Review 👀 to In Progress 🛠 in NGINX Ingress Controller Feb 13, 2025
@AlexFenlon AlexFenlon linked a pull request Feb 13, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
Status: In Progress 🛠
Development

Successfully merging a pull request may close this issue.

2 participants