Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify mime-type checks to support jpg and other image formats #2401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Nov 6, 2024

This PR should fix #2399

TODO:

  • deeper manual testing
  • check tests failures

@Koc Koc force-pushed the fix/fix-image-mime-type-checks branch from 40010de to fa0067f Compare November 6, 2024 22:50
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@39bd5df). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2401   +/-   ##
=======================================
  Coverage        ?   42.86%           
  Complexity      ?      854           
=======================================
  Files           ?       72           
  Lines           ?     3201           
  Branches        ?        0           
=======================================
  Hits            ?     1372           
  Misses          ?     1829           
  Partials        ?        0           

@Koc Koc requested a review from Chartman123 November 6, 2024 22:56
@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels Nov 7, 2024
@Chartman123
Copy link
Collaborator

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 7, 2024
@Chartman123
Copy link
Collaborator

@Koc I think we need some adjustments in the backport as we have the duplicated endpoints there.

@Chartman123 Chartman123 added this to the 5.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing common image mimetypes from file upload restricted for image type
2 participants