-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud 25 and PHP8.1 500 error #218
Comments
Nextcloud logs
|
linked to this picocms/Pico#608 |
Could we get an update to picoCMS v3 alpha 2?
|
I'm afraid this isn't feasible as an official release. The reason is that we end up getting two major breaking changes in a row: Pico 3.0.0-alpha.2 has breaking changes in comparison to Pico 2.1, and the upcoming final Pico 3.0 has breaking changes in comparison to Pico 3.0.0-alpha.2. The breaking changes are due to updated dependencies, which are also causing the incompatibilities (not the dependency's fault though, they are just outdated). We're not talking about some minor issue here and there, the update will break most themes due to the Twig update. Now the funny part: Actually everything is ready for release for months now, including the upgrade docs. It just needs testing. Unfortunately we didn't receive any feedback and I just don't have the time right now to do the required tests... You can give the final Pico 3.0 a try by following https://github.com/nextcloud/cms_pico#manually, but changing the version constraints to |
Thanks for the update, that helps a lot. I know my own sites are very simple, but an update to I did try and use If it helps, I can test some themes and see how things break |
also, I have had to remove my updated version as the news app doesnt work. Not sure why, very odd. Need to dig into why, unless you know |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! 👍 |
@PhrozenByte Here is some feedback regarding
|
@PhrozenByte Pico Plugin version 4 is missing. Attached is an updated patch file (I also locked the respective commits in the composer.json) |
Trying to convert the standard template to Twig 3, I encountered the following error:
EDIT2: ok it seems that this line in the template caused the issue: EDIT: @PhrozenByte Is it possible to start a separate branch in cms_pico where we can work on getting all the compatibility done for Pico 3 ? I could merge request all the work I have done so far in this branch, and while that branch works people could also use it for testing. |
Thanks for your contributions @derMart ❤️
Yeah, we should probably at least allow
Sure, simply fork the |
I am also affected by this problem.
This leads to an enormous log spam and sometimes the ExceptionSerializer is even unable to serialize the message, due to insufficient memory:
@PhrozenByte Could you reopen this issue now that it doesn't seem to be stale any more? |
This is a known bug in nextcloud/server, see nextcloud/server#23429 (comment) About your issue: Increase your log level resp. disable debug mode. The only reason these messages show up in your log is due to enabled debug logs. |
Yes, i noticed this as well and lowered my log level accordingly. |
@PhrozenByte I created the pull request. The idea about the extra branch was to have this inside your cms_pico repo, not inside my fork. Reasons are a) you can't push into my repo and b) people are not able to install my forked repo via composer, only a branch in your repo is possible. But if you merge the pull request and master branch is the beta, then I guess everything is fine (as folks can composer install your master branch for testing). If you have time, you might also have a look at #233 :-)
Good point. I did have a look into Twig 3.x core filters and to me it seems, they all allow null values. Example: Merry Christmas 🎄 :-) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! 👍 |
Sorry for jumping in. I am recently trying to setup NC24 with cms_pico and this thread is so much valuable and insightful. And I finally get it working! Besides the awesome PR #232 from @derMart , the only change that is needed is to make it working is to relax |
@PhrozenByte I've based PR #232 off from master, and wanted to use my branch inside a NC25 installation. Realized this doesn't work as appinfo only shows compatibility from NC22 to NC24. This is very confusing. I know that there is the v1.0.21 tag, where appinfo shows compatibility only to NC25, but well, is master branch not a continuation from v1.0.21 tag? So is master not compatible with NC25? Could you merge all the changes necessary from v.1.0.21 tag to master branch to make it compatible to NC25? And why is v.1.0.21 only compatible to NC25? Does that mean cms_pico will only be compatible to NC25 in the future or NC22-24 but not both? I can't believe that nextcloud does not make it possible for apps to be compatible for a whole range of versions ... :-( :-( |
Or well in other words: Which nextcloud versions will cms_pico 2.0 be compatible with? Hopefully not only >=NC25 ... |
Just for completeness, I created another branch |
That's due to major backwards incompatible frontend changes in Nextcloud 25. I simply hadn't enough time to implement the necessary changes in a backwards compatible manner, that's why v1.0.21 supports NC 25 only. I didn't make any decision yet whether v2.0 will support NC 24 (NC 23 is already EOL), but for now you can merge the changes of v1.0.21 (resp. the whole Thanks again for your great work! ❤️ |
I've just merged the |
Thanks for your great work guys ❤️ |
I rebased #232 to the current |
Good morning folks,
I have had a working install for many months, I have even updated to Nextcloud 25.0.1 and things are great. So I have upgraded PHP to 8.1, I now get an error out of PHP and many logs in Nextcloud.
I know this is PHP8.1 related as it was running fine in PHP7.4 and a switch to 8.1 broke it, what do you need from me to investigate and fix please?
The text was updated successfully, but these errors were encountered: