style(agent): drupal code formatting #1029
Conversation
|
bduranleau-nr
requested review from
ZNeumann,
zsistla,
mfulb,
lavarou and
hahuja2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1029 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 198 198
Lines 27715 27715
=======================================
Hits 21503 21503
Misses 6212 6212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
changed the title
agent/fw_drupal_common.h
Outdated
| * Purpose: Before an invoke_all style call, adds the hook to that hook states | ||
| * stacks | ||
| * | ||
| * Params : 1. A zval holding a copy of the hook invoked, to be managed by the hook | ||
| * states stacks and freed by nr_drupal_invoke_all_hook_stacks_pop() after the | ||
| * invoke_all call completes | ||
| * Params : 1. A zval holding a copy of the hook invoked, to be managed by the | ||
| * hook states stacks and freed by nr_drupal_invoke_all_hook_stacks_pop() after | ||
| * the invoke_all call completes |
There was a problem hiding this comment.
This doesn't seem right. The same file shows Purpose and Params docs strings, that span multiple lines, indented.
There was a problem hiding this comment.
I've manually fixed this here: fca6ace
For future reference, the reason for this is not due to a mis-configuration of clang-format. This is due to the line length limit (80 chars) and clang-format not being clever enough to match the indentation style in a docstring like this. These kinds of cases will require manual intervention.
No description provided.