Merge pull request #1 from s4ke/master

test with exponential backoff

Author: s4ke

.github/workflows/main.yaml

@@ -1,5 +1,9 @@
 name: main
-on: [push, pull_request]
+on: 
+  pull_request:
+  push:
+    branches:
+      - "*"
 jobs:
   test:
     env:
@@ -8,7 +12,9 @@ jobs:
       matrix:
         go: [ 1.19.x ]
         os: [ ubuntu-latest ]
-    name: ${{ matrix.os }}/go${{ matrix.go }}
+        arch:
+        - arm64
+        - amd64
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
@@ -19,4 +25,20 @@ jobs:
           go-version: ${{ matrix.go }}
 
       - run: make test
-    
+  test_build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        arch:
+        - arm64
+        - amd64
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+
+      - run: make create PLUGIN_NAME=ghcr.io/${{ github.repository }} PLUGIN_TAG=$(shell git describe --tags --exact-match 2> /dev/null || echo dev)-${{ matrix.arch }}

.github/workflows/release.yml

@@ -0,0 +1,48 @@
+name: Production Build
+
+on:
+  push:
+    tags:
+      - "v*.*.*"
+
+jobs:
+  release_build:
+    env:
+      LATEST_GO: 1.19.x # version used for release
+    strategy:
+      matrix:
+        go: [ 1.19.x ]
+        os: [ ubuntu-latest ]
+        arch:
+        - arm64
+        - amd64
+    name: ${{ matrix.os }}/go${{ matrix.go }} ${{ matrix.arch }}
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Setup go
+        uses: actions/setup-go@v3
+        with:
+          go-version: ${{ matrix.go }}
+
+      - run: make test
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+
+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Set env
+        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+
+      - run: |
+          make push PLUGIN_NAME=ghcr.io/${{ github.repository }} PLUGIN_TAG=$RELEASE_VERSION-${{ matrix.arch }} ARCH=${{ matrix.arch }}

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19.3-alpine as builder
+FROM --platform=$TARGETPLATFORM golang:1.19.3-alpine as builder
 
 ENV CGO_ENABLED=0
 
@@ -14,7 +14,7 @@ COPY . /plugin
 RUN go build -v
 
 
-FROM alpine
+FROM --platform=$TARGETPLATFORM alpine
 
 RUN apk add --update ca-certificates e2fsprogs xfsprogs
 

Makefile

@@ -1,5 +1,6 @@
 PLUGIN_NAME = costela/docker-volume-hetzner
 PLUGIN_TAG ?= $(shell git describe --tags --exact-match 2> /dev/null || echo dev)
+ARCH = amd64
 
 all: create
 
@@ -12,7 +13,7 @@ clean:
 	@docker container rm -vf tmp_plugin_build || true
 
 rootfs: clean
-	docker image build -t ${PLUGIN_NAME}:rootfs .
+	docker image build --platform=linux/${ARCH} -t ${PLUGIN_NAME}:rootfs .
 	mkdir -p ./plugin/rootfs
 	docker container create --name tmp_plugin_build ${PLUGIN_NAME}:rootfs
 	docker container export tmp_plugin_build | tar -x -C ./plugin/rootfs

README.md

@@ -1,6 +1,5 @@
 [![Go Report Card](https://goreportcard.com/badge/github.com/costela/docker-volume-hetzner)](https://goreportcard.com/report/github.com/costela/docker-volume-hetzner)
 ![tests](https://github.com/costela/docker-volume-hetzner/actions/workflows/main.yaml/badge.svg)
-[![Docker Hub Version](https://img.shields.io/badge/dynamic/json.svg?label=hub&url=https%3A%2F%2Findex.docker.io%2Fv1%2Frepositories%2Fcostela%2Fdocker-volume-hetzner%2Ftags&query=%24[-1:].name&colorB=green)](https://hub.docker.com/r/costela/docker-volume-hetzner)
 
 # Docker Volume Plugin for Hetzner Cloud
 
@@ -12,7 +11,7 @@ This plugin manages docker volumes using Hetzner Cloud's volumes.
 
 To install the plugin, run the following command:
 ```shell
-$ docker plugin install --alias hetzner costela/docker-volume-hetzner
+$ docker plugin install --alias hetzner ghcr.io/costela/docker-volume-hetzner:...-amd64
 ```
 
 When using Docker Swarm, this should be done on all nodes in the cluster.

driver.go

@@ -3,25 +3,45 @@ package main
 import (
 	"context"
 	"fmt"
+	"math"
 	"os"
 	"strconv"
 	"strings"
 	"time"
 
 	"github.com/docker/docker/pkg/mount"
 	"github.com/hashicorp/go-multierror"
+	"github.com/hetznercloud/hcloud-go/v2/hcloud"
 	"github.com/sirupsen/logrus"
 
 	"github.com/docker/go-plugins-helpers/volume"
-	"github.com/hetznercloud/hcloud-go/hcloud"
 )
 
 // used in methods that take &bools
 var trueVar = true
 var falseVar = false
 
 type hetznerDriver struct {
-	client hetznerClienter
+	client         hetznerClienter
+	nextTry        time.Time
+	failuresInARow int
+}
+
+func (hd *hetznerDriver) checkBackoff() error {
+	if time.Now().Before(hd.nextTry) {
+		return fmt.Errorf("last failure too recent; waiting a bit before retrying")
+	}
+	return nil
+}
+
+func (hd *hetznerDriver) handleBackoff(err error) {
+	if err == nil {
+		hd.failuresInARow = 0
+	}
+	if err != nil {
+		hd.nextTry = time.Now().Add(time.Duration(int64(math.Pow(2, float64(hd.failuresInARow)))) * time.Second)
+		hd.failuresInARow++
+	}
 }
 
 func newHetznerDriver() *hetznerDriver {
@@ -36,7 +56,7 @@ func (hd *hetznerDriver) Capabilities() *volume.CapabilitiesResponse {
 	}
 }
 
-func (hd *hetznerDriver) Create(req *volume.CreateRequest) error {
+func (hd *hetznerDriver) createInternal(req *volume.CreateRequest) error {
 	validateOptions(req.Name, req.Options)
 
 	prefixedName := prefixName(req.Name)
@@ -61,7 +81,7 @@ func (hd *hetznerDriver) Create(req *volume.CreateRequest) error {
 	}
 	switch f := getOption("fstype", req.Options); f {
 	case "xfs", "ext4":
-		opts.Format = hcloud.String(f)
+		opts.Format = hcloud.Ptr(f)
 	}
 
 	resp, _, err := hd.client.Volume().Create(context.Background(), opts)
@@ -118,7 +138,17 @@ func (hd *hetznerDriver) Create(req *volume.CreateRequest) error {
 	return nil
 }
 
-func (hd *hetznerDriver) List() (*volume.ListResponse, error) {
+func (hd *hetznerDriver) Create(req *volume.CreateRequest) error {
+	if err := hd.checkBackoff(); err != nil {
+		return err
+	}
+
+	err := hd.createInternal(req)
+	hd.handleBackoff(err)
+	return err
+}
+
+func (hd *hetznerDriver) listInternal() (*volume.ListResponse, error) {
 	logrus.Infof("got list request")
 
 	vols, err := hd.client.Volume().All(context.Background())
@@ -150,7 +180,17 @@ func (hd *hetznerDriver) List() (*volume.ListResponse, error) {
 	return &resp, nil
 }
 
-func (hd *hetznerDriver) Get(req *volume.GetRequest) (*volume.GetResponse, error) {
+func (hd *hetznerDriver) List() (*volume.ListResponse, error) {
+	if err := hd.checkBackoff(); err != nil {
+		return nil, err
+	}
+
+	resp, err := hd.listInternal()
+	hd.handleBackoff(err)
+	return resp, err
+}
+
+func (hd *hetznerDriver) getInternal(req *volume.GetRequest) (*volume.GetResponse, error) {
 	prefixedName := prefixName(req.Name)
 
 	logrus.Infof("fetching information for volume %q", prefixedName)
@@ -186,7 +226,17 @@ func (hd *hetznerDriver) Get(req *volume.GetRequest) (*volume.GetResponse, error
 	return &resp, nil
 }
 
-func (hd *hetznerDriver) Remove(req *volume.RemoveRequest) error {
+func (hd *hetznerDriver) Get(req *volume.GetRequest) (*volume.GetResponse, error) {
+	if err := hd.checkBackoff(); err != nil {
+		return nil, err
+	}
+
+	resp, err := hd.getInternal(req)
+	hd.handleBackoff(err)
+	return resp, err
+}
+
+func (hd *hetznerDriver) removeInternal(req *volume.RemoveRequest) error {
 	prefixedName := prefixName(req.Name)
 
 	logrus.Infof("starting volume removal for %q", prefixedName)
@@ -228,7 +278,17 @@ func (hd *hetznerDriver) Remove(req *volume.RemoveRequest) error {
 	return nil
 }
 
-func (hd *hetznerDriver) Path(req *volume.PathRequest) (*volume.PathResponse, error) {
+func (hd *hetznerDriver) Remove(req *volume.RemoveRequest) error {
+	if err := hd.checkBackoff(); err != nil {
+		return err
+	}
+
+	err := hd.removeInternal(req)
+	hd.handleBackoff(err)
+	return err
+}
+
+func (hd *hetznerDriver) pathInternal(req *volume.PathRequest) (*volume.PathResponse, error) {
 	prefixedName := prefixName(req.Name)
 
 	logrus.Infof("got path request for volume %q", prefixedName)
@@ -241,7 +301,17 @@ func (hd *hetznerDriver) Path(req *volume.PathRequest) (*volume.PathResponse, er
 	return &volume.PathResponse{Mountpoint: resp.Volume.Mountpoint}, nil
 }
 
-func (hd *hetznerDriver) Mount(req *volume.MountRequest) (*volume.MountResponse, error) {
+func (hd *hetznerDriver) Path(req *volume.PathRequest) (*volume.PathResponse, error) {
+	if err := hd.checkBackoff(); err != nil {
+		return nil, err
+	}
+
+	resp, err := hd.pathInternal(req)
+	hd.handleBackoff(err)
+	return resp, err
+}
+
+func (hd *hetznerDriver) mountInternal(req *volume.MountRequest) (*volume.MountResponse, error) {
 	prefixedName := prefixName(req.Name)
 
 	logrus.Infof("received mount request for %q as %q", prefixedName, req.ID)
@@ -313,7 +383,17 @@ func (hd *hetznerDriver) Mount(req *volume.MountRequest) (*volume.MountResponse,
 	return &volume.MountResponse{Mountpoint: mountpoint}, nil
 }
 
-func (hd *hetznerDriver) Unmount(req *volume.UnmountRequest) error {
+func (hd *hetznerDriver) Mount(req *volume.MountRequest) (*volume.MountResponse, error) {
+	if err := hd.checkBackoff(); err != nil {
+		return nil, err
+	}
+
+	resp, err := hd.mountInternal(req)
+	hd.handleBackoff(err)
+	return resp, err
+}
+
+func (hd *hetznerDriver) unmountInternal(req *volume.UnmountRequest) error {
 	prefixedName := prefixName(req.Name)
 
 	logrus.Infof("received unmount request for %q as %q", prefixedName, req.ID)
@@ -357,6 +437,16 @@ func (hd *hetznerDriver) Unmount(req *volume.UnmountRequest) error {
 	return nil
 }
 
+func (hd *hetznerDriver) Unmount(req *volume.UnmountRequest) error {
+	if err := hd.checkBackoff(); err != nil {
+		return err
+	}
+
+	err := hd.unmountInternal(req)
+	hd.handleBackoff(err)
+	return err
+}
+
 func (hd *hetznerDriver) getServerForLocalhost() (*hcloud.Server, error) {
 	hostname, err := os.Hostname()
 	if err != nil {

driver_testwrapper.go

@@ -3,7 +3,7 @@ package main
 import (
 	"context"
 
-	"github.com/hetznercloud/hcloud-go/hcloud"
+	"github.com/hetznercloud/hcloud-go/v2/hcloud"
 )
 
 // these types wrap hcloud.Client to make mocking easier
@@ -24,7 +24,7 @@ type hetznerVolumeClienter interface {
 }
 
 type hetznerServerClienter interface {
-	GetByID(ctx context.Context, id int) (*hcloud.Server, *hcloud.Response, error)
+	GetByID(ctx context.Context, id int64) (*hcloud.Server, *hcloud.Response, error)
 	GetByName(ctx context.Context, name string) (*hcloud.Server, *hcloud.Response, error)
 }