Skip to content

Commit ba88263

Browse files
committed
Replace UJson by ORJson - Client/Server do not work anymore
1 parent d2f1fa1 commit ba88263

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

Diff for: README.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Requirements
8686
- ``psutil`` (better with latest version)
8787
- ``defusedxml`` (in order to monkey patch xmlrpc)
8888
- ``packaging`` (for the version comparison)
89-
- ``ujson`` (an optimized alternative to the standard json module)
89+
- ``orjson`` (an optimized alternative to the standard json module)
9090

9191
*Note for Python 2 users*
9292

Diff for: doc-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
orjson
12
reuse
23
setuptools>=65.5.1 # not directly required, pinned by Snyk to avoid a vulnerability
34
sphinx
45
sphinx_rtd_theme
5-
ujson

Diff for: glances/client.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import sys
1212
import time
1313

14-
import ujson
14+
import orjson
1515

1616
from glances import __version__
1717
from glances.globals import Fault, ProtocolError, ServerProxy, Transport
@@ -118,7 +118,7 @@ def _login_glances(self):
118118
if __version__.split('.')[0] == client_version.split('.')[0]:
119119
# Init stats
120120
self.stats = GlancesStatsClient(config=self.config, args=self.args)
121-
self.stats.set_plugins(ujson.loads(self.client.getAllPlugins()))
121+
self.stats.set_plugins(orjson.loads(self.client.getAllPlugins()))
122122
logger.debug(f"Client version: {__version__} / Server version: {client_version}")
123123
else:
124124
self.log_and_exit(
@@ -195,7 +195,7 @@ def update_glances(self):
195195
"""
196196
# Update the stats
197197
try:
198-
server_stats = ujson.loads(self.client.getAll())
198+
server_stats = orjson.loads(self.client.getAll())
199199
except OSError:
200200
# Client cannot get server stats
201201
return "Disconnected"

Diff for: glances/client_browser.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import threading
1212

13-
import ujson
13+
import orjson
1414

1515
from glances.autodiscover import GlancesAutoDiscoverServer
1616
from glances.client import GlancesClient, GlancesClientTransport
@@ -95,12 +95,12 @@ def __update_stats(self, server):
9595
# Mandatory stats
9696
try:
9797
# CPU%
98-
cpu_percent = 100 - ujson.loads(s.getCpu())['idle']
98+
cpu_percent = 100 - orjson.loads(s.getCpu())['idle']
9999
server['cpu_percent'] = f'{cpu_percent:.1f}'
100100
# MEM%
101-
server['mem_percent'] = ujson.loads(s.getMem())['percent']
101+
server['mem_percent'] = orjson.loads(s.getMem())['percent']
102102
# OS (Human Readable name)
103-
server['hr_name'] = ujson.loads(s.getSystem())['hr_name']
103+
server['hr_name'] = orjson.loads(s.getSystem())['hr_name']
104104
except (OSError, Fault, KeyError) as e:
105105
logger.debug(f"Error while grabbing stats form server ({e})")
106106
server['status'] = 'OFFLINE'
@@ -120,7 +120,7 @@ def __update_stats(self, server):
120120
# Optional stats (load is not available on Windows OS)
121121
try:
122122
# LOAD
123-
load_min5 = ujson.loads(s.getLoad())['min5']
123+
load_min5 = orjson.loads(s.getLoad())['min5']
124124
server['load_min5'] = f'{load_min5:.2f}'
125125
except Exception as e:
126126
logger.warning(f"Error while grabbing stats form server ({e})")

Diff for: glances/globals.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
from xmlrpc.client import Fault, ProtocolError, Server, ServerProxy, Transport
3434
from xmlrpc.server import SimpleXMLRPCRequestHandler, SimpleXMLRPCServer
3535

36-
import ujson
36+
import orjson
3737

3838
# Correct issue #1025 by monkey path the xmlrpc lib
3939
from defusedxml.xmlrpc import monkey_patch
@@ -309,9 +309,9 @@ def json_dumps(data):
309309
Manage the issue #815 for Windows OS with UnicodeDecodeError catching.
310310
"""
311311
try:
312-
return ujson.dumps(data)
312+
return orjson.dumps(data)
313313
except UnicodeDecodeError:
314-
return ujson.dumps(data, ensure_ascii=False)
314+
return orjson.dumps(data, ensure_ascii=False)
315315

316316

317317
def dictlist(data, item):

Diff for: glances/plugins/ip/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import threading
1212

13-
from ujson import loads
13+
from orjson import loads
1414

1515
from glances.globals import queue, urlopen_auth
1616
from glances.logger import logger

Diff for: requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
defusedxml
2+
orjson>=5.4.0
23
packaging
34
psutil>=5.6.7
4-
ujson>=5.4.0

Diff for: tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ deps =
1818
psutil
1919
defusedxml
2020
packaging
21-
ujson
21+
orjson
2222
fastapi
2323
uvicorn
2424
jinja2

0 commit comments

Comments
 (0)