Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General way of exposing values from k8s objects into metrics #1305

Open
Omrigan opened this issue Mar 6, 2025 · 1 comment
Open

General way of exposing values from k8s objects into metrics #1305

Omrigan opened this issue Mar 6, 2025 · 1 comment

Comments

@Omrigan
Copy link
Contributor

Omrigan commented Mar 6, 2025

Problem description / Motivation

We have lots of useful info available on VM/VMM/other objects. But once the object is deleted from k8s, we have no way of looking at what happened to an object.

One specific example I had in mind is exposing migration info, so that we can calculate stats:

migration.Status.Info.Status = migrationInfo.Status
migration.Status.Info.TotalTimeMs = migrationInfo.TotalTimeMs
migration.Status.Info.SetupTimeMs = migrationInfo.SetupTimeMs
migration.Status.Info.DowntimeMs = migrationInfo.DowntimeMs
migration.Status.Info.Ram.Transferred = migrationInfo.Ram.Transferred
migration.Status.Info.Ram.Remaining = migrationInfo.Ram.Remaining
migration.Status.Info.Ram.Total = migrationInfo.Ram.Total
migration.Status.Info.Compression.CompressedSize = migrationInfo.Compression.CompressedSize
migration.Status.Info.Compression.CompressionRate = int64(math.Round(migrationInfo.Compression.CompressionRate))

Feature idea(s) / DoD

We have a clear way of adding new values to be exposed, and we understand what guarantees we have around it.

Implementation ideas

We already have per-VM metrics in agent, do we want to keep using it, and improve?

Maybe there is a standard way to do it in k8s already?

@Omrigan
Copy link
Contributor Author

Omrigan commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant