Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit VMMigration controller code #1233

Open
Tracked by #832
Omrigan opened this issue Jan 31, 2025 · 2 comments
Open
Tracked by #832

Audit VMMigration controller code #1233

Omrigan opened this issue Jan 31, 2025 · 2 comments
Assignees
Labels
a/tech_debt Area: related to tech debt c/autoscaling/neonvm Component: autoscaling: NeonVM

Comments

@Omrigan
Copy link
Contributor

Omrigan commented Jan 31, 2025

VMMigration controller code is a bit neglected, as it didn't have any production use. We should fix it.

  1. Assess the tech debt, fix what can be fixed fast.
  2. Take a closer look at the state machine, see if there are any potentially problematic states.
    • E.g. Migrating + Scaling; Migrating + Deleting
  3. Assess the possibility of merging VMMigration controller into the VM controller.
    • E. g. it makes state machine simpler to understand
@sharnoff sharnoff added the c/autoscaling/neonvm Component: autoscaling: NeonVM label Feb 3, 2025
@stradig stradig added the a/tech_debt Area: related to tech debt label Feb 10, 2025
@mikhail-sakhnov
Copy link
Contributor

We once discussed auditing reasonability of having RECEIVE_MIGRATION=true after finishing the migration, more context here #1190 (comment)

@Omrigan
Copy link
Contributor Author

Omrigan commented Feb 23, 2025

One more thing to look at is failure to simultaneously transition VM and VMM states

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/autoscaling/neonvm Component: autoscaling: NeonVM
Projects
None yet
Development

No branches or pull requests

4 participants