Skip to content

Commit 76551d0

Browse files
mikhail-sakhnovsharnoff
authored andcommitted
neonvm: apply ci fixes for extracted control daemon
Signed-off-by: Misha Sakhnov <[email protected]>
1 parent 4cdc836 commit 76551d0

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

.github/workflows/build-images.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ on:
4646
autoscaler-agent:
4747
description: 'autoscaler-agent image'
4848
value: ${{ jobs.tags.outputs.autoscaler-agent }}
49+
daemon:
50+
description: 'neonvm-daemon image'
51+
value: ${{ jobs.tags.outputs.daemon }}
4952

5053
env:
5154
IMG_CONTROLLER: "neondatabase/neonvm-controller"
@@ -79,6 +82,7 @@ jobs:
7982
scheduler: ${{ steps.show-tags.outputs.scheduler }}
8083
autoscaler-agent: ${{ steps.show-tags.outputs.autoscaler-agent }}
8184
cluster-autoscaler: ${{ steps.show-tags.outputs.cluster-autoscaler }}
85+
daemon: ${{ steps.show-tags.outputs.daemon}}
8286
runs-on: ubuntu-latest
8387
steps:
8488
- id: show-tags
@@ -241,6 +245,8 @@ jobs:
241245
push: true
242246
file: neonvm/daemon/Dockerfile
243247
tags: ${{ needs.tags.outputs.daemon }}
248+
build-args: |
249+
GO_BASE_IMG=${{ env.GO_BASE_IMG }}
244250
245251
- name: Generate neonvm-controller build tags
246252
id: controller-build-tags

.github/workflows/build-test-vm.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ on:
2929

3030
env:
3131
IMG_POSTGRES_16_BULLSEYE: "neondatabase/vm-postgres-16-bullseye"
32+
IMG_DAEMON: "neondatabase/neonvm-daemon"
3233

3334
defaults:
3435
run:
@@ -38,11 +39,13 @@ jobs:
3839
tags:
3940
outputs:
4041
vm-postgres-16-bullseye: ${{ steps.show-tags.outputs.vm-postgres-16-bullseye }}
42+
daemon: ${{ steps.show-tags.outputs.daemon }}
4143
runs-on: ubuntu-latest
4244
steps:
4345
- id: show-tags
4446
run: |
4547
echo "vm-postgres-16-bullseye=${{ env.IMG_POSTGRES_16_BULLSEYE }}:${{ inputs.tag }}" | tee -a $GITHUB_OUTPUT
48+
echo "daemon=${{ env.IMG_DAEMON }}:${{ inputs.tag }}" | tee -a $GITHUB_OUTPUT
4649
4750
build:
4851
# nb: use format(..) to catch both inputs.skip = true AND inputs.skip = 'true'.
@@ -81,7 +84,7 @@ jobs:
8184

8285
- name: build ${{ needs.tags.outputs.vm-postgres-16-bullseye }}
8386
run: |
84-
./bin/vm-builder -src postgres:16-bullseye -spec tests/e2e/image-spec.yaml -dst ${{ needs.tags.outputs.vm-postgres-16-bullseye }}
87+
./bin/vm-builder -src postgres:16-bullseye -spec tests/e2e/image-spec.yaml -dst ${{ needs.tags.outputs.vm-postgres-16-bullseye }} -daemon-image ${{ needs.tags.outputs.daemon }}
8588
- name: docker push ${{ needs.tags.outputs.vm-postgres-16-bullseye }}
8689
run: |
8790
docker push ${{ needs.tags.outputs.vm-postgres-16-bullseye }}

Makefile

+6-2
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ build: fmt vet bin/vm-builder ## Build all neonvm binaries.
133133
GOOS=linux go build -o bin/runner neonvm/runner/*.go
134134

135135
.PHONY: bin/vm-builder
136-
bin/vm-builder: docker-build-daemon ## Build vm-builder binary.
136+
bin/vm-builder: ## Build vm-builder binary.
137137
GOOS=linux CGO_ENABLED=0 go build -o bin/vm-builder -ldflags "-X main.Version=${GIT_INFO} -X main.NeonvmDaemonImage=${IMG_DAEMON}" neonvm/tools/vm-builder/main.go
138138

139139
.PHONY: run
@@ -185,7 +185,11 @@ docker-build-runner: docker-build-go-base ## Build docker image for NeonVM runne
185185

186186
.PHONY: docker-build-daemon
187187
docker-build-daemon: ## Build docker image for NeonVM daemon.
188-
docker build -t $(IMG_DAEMON) -f neonvm/daemon/Dockerfile .
188+
docker build \
189+
--tag $(IMG_DAEMON) \
190+
--build-arg GO_BASE_IMG=$(GO_BASE_IMG) \
191+
--file neonvm/daemon/Dockerfile \
192+
.
189193

190194
.PHONY: docker-build-vxlan-controller
191195
docker-build-vxlan-controller: docker-build-go-base ## Build docker image for NeonVM vxlan controller

0 commit comments

Comments
 (0)