From c80277698c881cce97e5fd06700cfd6658e9ae4b Mon Sep 17 00:00:00 2001 From: Yurii Sharko Date: Sat, 28 Dec 2024 14:20:31 +0200 Subject: [PATCH 1/3] Fixed signing issue --- packages/client/src/transactions/sign_and_send.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client/src/transactions/sign_and_send.ts b/packages/client/src/transactions/sign_and_send.ts index c555d3f6f..ef3736e01 100644 --- a/packages/client/src/transactions/sign_and_send.ts +++ b/packages/client/src/transactions/sign_and_send.ts @@ -15,7 +15,7 @@ const DEFAULT_FINALITY: BlockReference = { finality: 'final' }; * @param signer MessageSigner */ export async function signTransaction({ transaction, deps: { signer } }: SignTransactionParams) { - const encodedTx = transaction.encode(); + const encodedTx = new Uint8Array(sha256.sha256.array(transaction.encode())); const signedTransaction = new SignedTransaction({ transaction, signature: new Signature({ From bea74bdb810ec528051ac4ead03ee3201cbbf5b2 Mon Sep 17 00:00:00 2001 From: Yurii Sharko Date: Sat, 28 Dec 2024 14:42:52 +0200 Subject: [PATCH 2/3] Fixed return --- packages/client/src/transactions/sign_and_send.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client/src/transactions/sign_and_send.ts b/packages/client/src/transactions/sign_and_send.ts index ef3736e01..634369d41 100644 --- a/packages/client/src/transactions/sign_and_send.ts +++ b/packages/client/src/transactions/sign_and_send.ts @@ -25,7 +25,7 @@ export async function signTransaction({ transaction, deps: { signer } }: SignTra }); return { - encodedTransactionHash: new Uint8Array(sha256(encodedTx)), + encodedTransactionHash: encodedTx, signedTransaction, }; } From 5afd9dbf8f1ac3bc070645098fa59020a571d30d Mon Sep 17 00:00:00 2001 From: AlexKushnir1 Date: Fri, 3 Jan 2025 18:39:12 +0200 Subject: [PATCH 3/3] fix: passed correct ts hash func --- packages/client/src/transactions/sign_and_send.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client/src/transactions/sign_and_send.ts b/packages/client/src/transactions/sign_and_send.ts index 634369d41..76629d3b5 100644 --- a/packages/client/src/transactions/sign_and_send.ts +++ b/packages/client/src/transactions/sign_and_send.ts @@ -15,7 +15,7 @@ const DEFAULT_FINALITY: BlockReference = { finality: 'final' }; * @param signer MessageSigner */ export async function signTransaction({ transaction, deps: { signer } }: SignTransactionParams) { - const encodedTx = new Uint8Array(sha256.sha256.array(transaction.encode())); + const encodedTx = new Uint8Array(sha256(transaction.encode())); const signedTransaction = new SignedTransaction({ transaction, signature: new Signature({