fix total dao funds update (#694)

Author: andkom

.env

@@ -53,7 +53,7 @@ NOTIFI_SECRET=NOTIFI_SECRET
 NOTIFI_PREFIX="dev"
 
 AGGREGATOR_EXPIRED_PROPOSALS_POLLING_INTERVAL=60000
-AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=100000
+AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=3600000
 # 12 hours
 AGGREGATOR_DAO_STATUS_POLLING_INTERVAL=43200000
 # Every day at 23:55

.github/env.production

@@ -9,7 +9,7 @@ HELM_FRONTEND_URL=https://app.astrodao.com
 HELM_NEAR_BRIDGE_TOKEN_FACTORY_CONTRACT_NAME=factory.bridge.near
 HELM_HELM_NEAR_NFT_WHITELIST_CONTRACTS=starpause.mintbase1.near
 HELM_NEAR_TOKEN_API_URL=https://api.stats.ref.finance/api
-HELM_AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=100000
+HELM_AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=3600000
 # 12 hours
 HELM_AGGREGATOR_DAO_STATUS_POLLING_INTERVAL=43200000
 # Every day at 23:55

.github/env.test

@@ -9,7 +9,7 @@ HELM_FRONTEND_URL=https://testnet.app.astrodao.com
 HELM_NEAR_BRIDGE_TOKEN_FACTORY_CONTRACT_NAME=f.ropsten.testnet
 HELM_TEST_ENV_NAME=testnet
 HELM_NEAR_TOKEN_API_URL=https://api.stats.ref.finance/api
-HELM_AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=100000
+HELM_AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL=3600000
 # 12 hours
 HELM_AGGREGATOR_DAO_STATUS_POLLING_INTERVAL=43200000
 # Every day at 23:55

apps/aggregator/deployment/app-chart/values.yaml

@@ -95,7 +95,7 @@ environment:
   NEAR_TOKEN_FACTORY_CONTRACT_NAME: "tokenfactory.testnet"
   NEAR_BRIDGE_TOKEN_FACTORY_CONTRACT_NAME: "f.ropsten.testnet"
   AGGREGATOR_EXPIRED_PROPOSALS_POLLING_INTERVAL: "60000"
-  AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL: "100000"
+  AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL: "3600000"
   # 12 hours
   AGGREGATOR_DAO_STATUS_POLLING_INTERVAL: "43200000"
   # Every day at 23:55

apps/aggregator/src/dao-aggregator/dao-aggregator.service.ts

@@ -62,7 +62,10 @@ export class DaoAggregatorService {
         );
       })
       .process((dao) =>
-        this.daoService.save(dao, { updateTotalDaoFunds: true }),
+        this.daoService.save(
+          { id: dao.id },
+          { updateTotalDaoFunds: true, allowDynamo: false },
+        ),
       );
   }
 

apps/api/deployment/app-chart/values.yaml

@@ -97,11 +97,5 @@ monitoring:
       port: api
 
 environment:
-  AGGREGATOR_EXPIRED_PROPOSALS_POLLING_INTERVAL: "60000"
-  AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL: "100000"
-  # 12 hours
-  AGGREGATOR_DAO_STATUS_POLLING_INTERVAL: "43200000"
-  # Every day at 23:55
-  AGGREGATOR_DAO_STATS_CRON_TIME: "55 23 * * *"
   API_RATE_TTL: "60"
   API_RATE_LIMIT: "5"

apps/draft/deployment/app-chart/values.yaml

@@ -90,12 +90,4 @@ monitoring:
     - path: /api/v1/metrics
       port: api
 
-environment:
-  AGGREGATOR_EXPIRED_PROPOSALS_POLLING_INTERVAL: "60000"
-  AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL: "100000"
-  # 12 hours
-  AGGREGATOR_DAO_STATUS_POLLING_INTERVAL: "43200000"
-  # Every day at 23:55
-  AGGREGATOR_DAO_STATS_CRON_TIME: "55 23 * * *"
-  API_RATE_TTL: "60"
-  API_RATE_LIMIT: "5"
+environment: {}

apps/notifier/deployment/app-chart/values.yaml

@@ -89,6 +89,4 @@ version:
   commit: latest
   branch: develop
 
-environment:
-  AGGREGATOR_EXPIRED_PROPOSALS_POLLING_INTERVAL: "60000"
-  AGGREGATOR_TOKEN_PRICES_POLLING_INTERVAL: "100000"
+environment: {}

libs/dynamodb/src/dynamodb.service.ts

@@ -247,11 +247,6 @@ export class DynamodbService {
     checkIfExists = true,
     tableName = this.tableName,
   ): Promise<PartialEntity<M> | undefined> {
-    this.logger.debug(
-      `[DynamoDB] Update: ${data.partitionId}:${
-        data.entityId
-      } (${JSON.stringify(data)})`,
-    );
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const { partitionId, entityId, entityType, ...rest } = data;
     const dataToUpdate = {
@@ -293,10 +288,14 @@ export class DynamodbService {
         ReturnValues: 'ALL_NEW',
       })
       .promise()
-      .then(
-        ({ Attributes }) =>
-          this.denormalizeData(Attributes) as PartialEntity<M>,
-      );
+      .then(({ Attributes }) => {
+        this.logger.debug(
+          `[DynamoDB] Update: ${data.partitionId}:${
+            data.entityId
+          } (${JSON.stringify(data)})`,
+        );
+        return this.denormalizeData(Attributes) as PartialEntity<M>;
+      });
   }
 
   async updateItemByType<M>(
@@ -553,7 +552,6 @@ export class DynamodbService {
     checkIfExists = true,
     tableName = this.tableName,
   ): Promise<PartialEntity<M>> {
-    this.logger.debug(`[DynamoDB] Put: ${data.partitionId}:${data.entityId}`);
     const timestamp = Date.now();
     const dataToPut = {
       createdAt: timestamp,
@@ -572,7 +570,14 @@ export class DynamodbService {
           : {}),
       })
       .promise()
-      .then(() => this.denormalizeData(dataToPut));
+      .then(() => {
+        this.logger.debug(
+          `[DynamoDB] Put: ${data.partitionId}:${
+            data.entityId
+          } (${JSON.stringify(dataToPut)})`,
+        );
+        return this.denormalizeData(dataToPut) as PartialEntity<M>;
+      });
   }
 
   async putItemByType<M>(

libs/transaction-handler/src/transaction-action-handler.service.ts

@@ -1373,7 +1373,11 @@ export class TransactionActionHandlerService {
           `Received NFTs from RPC: ${JSON.stringify(nftData)}`,
         );
         await this.daoService.save(
-          { id: accountId },
+          {
+            id: accountId,
+            updateTransactionHash: transactionHash,
+            updateTimestamp: timestamp,
+          },
           { updateNftsCount: true },
         );
         this.log(