Skip to content

Commit 6201b4b

Browse files
committed
More renaming
1 parent 8b6c820 commit 6201b4b

File tree

5 files changed

+22
-22
lines changed

5 files changed

+22
-22
lines changed

packages/application-extension/src/index.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -515,13 +515,13 @@ const topVisibility: JupyterFrontEndPlugin<void> = {
515515
optional: [IMainMenu, ISettingRegistry],
516516
activate: (
517517
app: JupyterFrontEnd<JupyterFrontEnd.IShell>,
518-
retroShell: INotebookShell,
518+
notebookShell: INotebookShell,
519519
translator: ITranslator,
520520
menu: IMainMenu | null,
521521
settingRegistry: ISettingRegistry | null
522522
) => {
523523
const trans = translator.load('jupyter-notebook');
524-
const top = retroShell.top;
524+
const top = notebookShell.top;
525525
const pluginId = topVisibility.id;
526526

527527
app.commands.addCommand(CommandIDs.toggleTop, {
@@ -568,9 +568,9 @@ const topVisibility: JupyterFrontEndPlugin<void> = {
568568
return;
569569
}
570570
if (app.format === 'desktop') {
571-
retroShell.expandTop();
571+
notebookShell.expandTop();
572572
} else {
573-
retroShell.collapseTop();
573+
notebookShell.collapseTop();
574574
}
575575
};
576576

@@ -677,22 +677,22 @@ const zen: JupyterFrontEndPlugin<void> = {
677677
app: JupyterFrontEnd,
678678
translator: ITranslator,
679679
palette: ICommandPalette | null,
680-
retroShell: INotebookShell | null,
680+
notebookShell: INotebookShell | null,
681681
menu: IMainMenu | null
682682
): void => {
683683
const { commands } = app;
684684
const elem = document.documentElement;
685685
const trans = translator.load('jupyter-notebook');
686686

687687
const toggleOn = () => {
688-
retroShell?.collapseTop();
689-
retroShell?.menu.setHidden(true);
688+
notebookShell?.collapseTop();
689+
notebookShell?.menu.setHidden(true);
690690
zenModeEnabled = true;
691691
};
692692

693693
const toggleOff = () => {
694-
retroShell?.expandTop();
695-
retroShell?.menu.setHidden(false);
694+
notebookShell?.expandTop();
695+
notebookShell?.menu.setHidden(false);
696696
zenModeEnabled = false;
697697
};
698698

packages/documentsearch-extension/src/index.ts

+8-8
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ const disableShortcut: JupyterFrontEndPlugin<void> = {
3939
/**
4040
* A plugin to add document search functionalities.
4141
*/
42-
const retroShellWidgetListener: JupyterFrontEndPlugin<void> = {
43-
id: '@jupyter-notebook/documentsearch-extension:retroShellWidgetListener',
42+
const notebookShellWidgetListener: JupyterFrontEndPlugin<void> = {
43+
id: '@jupyter-notebook/documentsearch-extension:notebookShellWidgetListener',
4444
requires: [INotebookShell, ISearchProviderRegistry],
4545
autoStart: true,
4646
activate: (
4747
app: JupyterFrontEnd,
48-
retroShell: INotebookShell,
48+
notebookShell: INotebookShell,
4949
registry: ISearchProviderRegistry
5050
) => {
5151
// If a given widget is searchable, apply the searchable class.
@@ -67,15 +67,15 @@ const retroShellWidgetListener: JupyterFrontEndPlugin<void> = {
6767
// changes, in case a provider for the current widget was added
6868
// or removed
6969
registry.changed.connect(() =>
70-
transformWidgetSearchability(retroShell.currentWidget)
70+
transformWidgetSearchability(notebookShell.currentWidget)
7171
);
7272

7373
// Apply the searchable class only to the active widget if it is actually
7474
// searchable. Remove the searchable class from a widget when it's
7575
// no longer active.
76-
retroShell.currentChanged.connect((_, args) => {
77-
if (retroShell.currentWidget) {
78-
transformWidgetSearchability(retroShell.currentWidget);
76+
notebookShell.currentChanged.connect((_, args) => {
77+
if (notebookShell.currentWidget) {
78+
transformWidgetSearchability(notebookShell.currentWidget);
7979
}
8080
});
8181
}
@@ -86,7 +86,7 @@ const retroShellWidgetListener: JupyterFrontEndPlugin<void> = {
8686
*/
8787
const plugins: JupyterFrontEndPlugin<any>[] = [
8888
disableShortcut,
89-
retroShellWidgetListener
89+
notebookShellWidgetListener
9090
];
9191

9292
export default plugins;

packages/lab-extension/src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const launchButtons: JupyterFrontEndPlugin<void> = {
7474
notebookTracker: INotebookTracker | null,
7575
palette: ICommandPalette | null,
7676
menu: IMainMenu | null,
77-
retroShell: INotebookShell | null,
77+
notebookShell: INotebookShell | null,
7878
labShell: ILabShell | null,
7979
toolbarRegistry: IToolbarWidgetRegistry | null
8080
) => {
@@ -132,7 +132,7 @@ const launchButtons: JupyterFrontEndPlugin<void> = {
132132
urlPrefix: `${baseUrl}tree/`
133133
});
134134

135-
if (!retroShell) {
135+
if (!notebookShell) {
136136
addInterface({
137137
command: 'jupyter-notebook:open-retro',
138138
commandLabel: trans.__('Open With %1', 'Jupyter Notebook'),

packages/notebook-extension/src/index.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const checkpoints: JupyterFrontEndPlugin<void> = {
6565
app: JupyterFrontEnd,
6666
docManager: IDocumentManager,
6767
translator: ITranslator,
68-
retroShell: INotebookShell | null
68+
notebookShell: INotebookShell | null
6969
) => {
7070
const { shell } = app;
7171
const trans = translator.load('jupyter-notebook');
@@ -95,8 +95,8 @@ const checkpoints: JupyterFrontEndPlugin<void> = {
9595
);
9696
};
9797

98-
if (retroShell) {
99-
retroShell.currentChanged.connect(onChange);
98+
if (notebookShell) {
99+
notebookShell.currentChanged.connect(onChange);
100100
}
101101

102102
new Poll({

0 commit comments

Comments
 (0)