Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run e2e tests in Docker #735

Closed
lorenyu opened this issue Aug 15, 2024 · 2 comments · Fixed by #770
Closed

Ability to run e2e tests in Docker #735

lorenyu opened this issue Aug 15, 2024 · 2 comments · Fixed by #770
Assignees
Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Aug 15, 2024

Currently e2e tests require locally installing playwright and all browser dependencies like chromium. It would improve portability, especially for projects where people are using Windows machines, to be able to run this in Docker. We could still keep the option to run natively.

cc @rylew1 we talked about this in one of the earlier PR reviews on your PR that first added e2e tests

@lorenyu lorenyu changed the title Dockerize e2e tests Ability to run e2e tests in Docker Aug 15, 2024
@lorenyu lorenyu added this to the 1-End-to-end (e2e) Testing milestone Aug 15, 2024
@lorenyu lorenyu added type: feature New feature or new functionality to existing feature scope: ci/cd GitHub actions workflows labels Aug 15, 2024
@lorenyu
Copy link
Contributor Author

lorenyu commented Aug 15, 2024

@lamroger-nava added this ticket since I remember you mentioning it. Were you already planning on working on this for the project? If so, I'll wait till you do that and pull it back into the template once you have.

@rylew1
Copy link
Contributor

rylew1 commented Oct 16, 2024

Related comment here for e2e deps:

navapbc/platform-test-nextjs#85 (comment)

@rylew1 rylew1 self-assigned this Oct 28, 2024
@rylew1 rylew1 mentioned this issue Oct 29, 2024
rylew1 added a commit that referenced this issue Oct 30, 2024
## Ticket

#735

## Changes

- dockerize e2e tests with playwright
- Tested on `platform-test-nextjs` => navapbc/platform-test-nextjs#88
rylew1 added a commit that referenced this issue Oct 30, 2024
## Ticket

- Fast follow to #735

## Changes
- Move e2e targets above infra targets
- Give infra targets a comment block header
- Give lint target a comment block header
@lorenyu lorenyu closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants