Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(dependencies): update types for react, node #282

Closed
wants to merge 1 commit into from
Closed

build(dependencies): update types for react, node #282

wants to merge 1 commit into from

Conversation

sbolel
Copy link

@sbolel sbolel commented Jan 17, 2024 •
edited
Loading

Ticket

Partially resolves #47, updating @types for react and node:

  • chore(deps): update react
    • @types/react
    • @types/react-dom
  • fix(deps): update all non-major dependencies
    • @aws-sdk/client-evidently
    • @types/node
    • @typescript-eslint/eslint-plugin
    • @typescript-eslint/parser
    • eslint
    • eslint-config-next
    • eslint-config-prettier
    • next
    • next-intl
    • style-loader
    • typescript

Changes

Updates the following devDependencies by versions acceptable to the lock (to the "Wanted" versions in the table below)

| Package          | Current | Wanted  | Latest (for reference only) |
| ---------------- | ------- | ------- | --------------------------- |
| @types/node      | 20.10.0 | 20.11.5 | 20.11.5                     |
| @types/react     | 18.2.42 | 18.2.48 | 18.2.48                     |
| @types/react-dom | 18.2.17 | 18.2.18 | 18.2.18                     |

Context for reviewers

Manual QA steps:

  • ensure no type errors are thrown in files inside IDE
  • ensure all linters, tests, and builds pass

Testing

  • ✅ npm run test
  • ✅ npm run lint
  • ✅ npm run format-check
  • ✅ npm run storybook-build
  • ✅ npm run build
  • ✅ npm run ts:check
  • ❌ CI tests are failing when trying to publish coverage report, perhaps due to permissions? see Details

sawyerh
sawyerh approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@sawyerh sawyerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbolel. For additional context, #47 is a constantly updating ticket. When a maintainer checks a box in the ticket, it'll automatically create a PR with those dependency updates. I believe it's setup to automatically create a PR monthly.

@sbolel
Copy link
Author

sbolel commented Jan 17, 2024

@sawyerh ah gotcha. I checked that but didn't see activity on it in some time, so I figured I'd do it manually 😄 -- I can ignore the rest of them if maintainers plan to check the boxes!

@sawyerh
Copy link
Contributor

sawyerh commented Jan 17, 2024

Going to close this in favor of #283 since something about the Test Coverage action doesn't like forked branches, which we'll debug separately.

@sawyerh sawyerh closed this Jan 17, 2024
@sbolel
Copy link
Author

sbolel commented Jan 17, 2024

Great, thanks!

@sbolel sbolel deleted the build/upgrade-dependencies/types branch January 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawyerh sawyerh sawyerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Dashboard
2 participants
@sbolel @sawyerh