Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Manual Routing docs #330

Open
rigor789 opened this issue Mar 8, 2020 · 0 comments
Open

Revise Manual Routing docs #330

rigor789 opened this issue Mar 8, 2020 · 0 comments
Assignees

Comments

@rigor789
Copy link
Member

rigor789 commented Mar 8, 2020

Most apps are written with webpack and .vue files by default. In the docs we're writing js only components.

We should revise the docs and update them to include up-to-date examples with .vue files and how that might look/work in an actual app.

We're also showing an example of navigating in an inline event handler @tap="$navigateTo(detailPage)" which requires adding detailPage to data. This is not a recommended approach, as this forces vue to mark the component descriptor as reactive. Instead we should focus on making sure that the component that we want to navigate to is imported, and the call to $navigateTo is made inside an event handler method.

I would propose we change the title from Manual Routing to just Navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant