List repos by authorization

Co-Authored-By: Trong Huu Nguyen <[email protected]>

Author: Reasonable-Solutions

internal/database/gensql/mock_querier.go

@@ -19,3 +19,15 @@ WHERE
     AND github_repository = @github_repository
 ORDER BY
     repository_authorization;
+
+
+-- name: ListRepositoriesByAuthorization :many
+SELECT
+    github_repository
+FROM
+    repository_authorizations
+WHERE
+    team_slug = @team_slug
+    AND repository_authorization = @repository_authorization
+ORDER BY -- The linter requires order by to be upper cased, lol
+    github_repository;

internal/database/gensql/querier.go

@@ -11,6 +11,7 @@ type RepositoryAuthorizationRepo interface {
 	CreateRepositoryAuthorization(ctx context.Context, teamSlug slug.Slug, repoName string, authorization gensql.RepositoryAuthorizationEnum) error
 	GetRepositoryAuthorizations(ctx context.Context, teamSlug slug.Slug, repoName string) ([]gensql.RepositoryAuthorizationEnum, error)
 	RemoveRepositoryAuthorization(ctx context.Context, teamSlug slug.Slug, repoName string, authorization gensql.RepositoryAuthorizationEnum) error
+	ListRepositoriesByAuthorization(ctx context.Context, teamSlug slug.Slug, authorization gensql.RepositoryAuthorizationEnum) ([]string, error)
 }
 
 func (d *database) CreateRepositoryAuthorization(ctx context.Context, teamSlug slug.Slug, repoName string, authorization gensql.RepositoryAuthorizationEnum) error {
@@ -35,3 +36,10 @@ func (d *database) GetRepositoryAuthorizations(ctx context.Context, teamSlug slu
 		GithubRepository: repoName,
 	})
 }
+
+func (d *database) ListRepositoriesByAuthorization(ctx context.Context, teamSlug slug.Slug, authorization gensql.RepositoryAuthorizationEnum) ([]string, error) {
+	return d.querier.ListRepositoriesByAuthorization(ctx, gensql.ListRepositoriesByAuthorizationParams{
+		TeamSlug:                teamSlug,
+		RepositoryAuthorization: authorization,
+	})
+}

internal/database/gensql/repository_authorizations.sql.go

@@ -2,7 +2,7 @@ package grpc
 
 import (
 	"context"
-	"encoding/json"
+	"fmt"
 
 	"github.com/google/uuid"
 	"github.com/nais/api/internal/database"
@@ -151,40 +151,14 @@ func (t *TeamsServer) Environments(ctx context.Context, req *protoapi.ListTeamEn
 }
 
 func (t *TeamsServer) ListAuthorizedRepositories(ctx context.Context, req *protoapi.ListAuthorizedRepositoriesRequest) (*protoapi.ListAuthorizedRepositoriesResponse, error) {
-	teamSlug := slug.Slug(req.Slug)
-
-	// get all repositories for team
-	res, err := t.db.GetReconcilerStateForTeam(ctx, "github:team", teamSlug)
-	if err != nil {
-		return nil, status.Errorf(codes.Internal, "fetching github repositories for team: %s", err)
-	}
-
-	var state struct {
-		Repos []struct {
-			Name string `json:"name"`
-		} `json:"repositories"`
-	}
-
-	err = json.Unmarshal(res.Value, &state)
+	teamSlug := slug.Slug(req.TeamSlug)
+	repositories, err := t.db.ListRepositoriesByAuthorization(ctx, teamSlug, gensql.RepositoryAuthorizationEnumDeploy)
 	if err != nil {
-		return nil, err
-	}
-
-	// filter out repositories without authorizations
-	filtered := make([]string, 0)
-	for _, repo := range state.Repos {
-		authorizations, err := t.db.GetRepositoryAuthorizations(ctx, teamSlug, repo.Name)
-		if err != nil {
-			return nil, status.Errorf(codes.Internal, "fetching authorization for repository: %s", err)
-		}
-
-		if len(authorizations) > 0 {
-			filtered = append(filtered, repo.Name)
-		}
+		return nil, fmt.Errorf("list repositories by authorization: %w", err)
 	}
 
 	return &protoapi.ListAuthorizedRepositoriesResponse{
-		GithubRepositories: filtered,
+		GithubRepositories: repositories,
 	}, nil
 }
 

internal/database/mock_database.go

@@ -16,7 +16,7 @@ message Team {
 }
 
 message ListAuthorizedRepositoriesRequest {
-  string slug = 1;
+  string teamSlug = 1;
 }
 
 message ListAuthorizedRepositoriesResponse {